Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1241077

Re: Re: [RFC][PATCH v3 3/3] input: i8042: Avoid resetting controller on system suspend/resume

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Rafael,

[auto build test ERROR on v4.3-rc4 -- if it's inappropriate base, please ignore]

config: i386-randconfig-i1-201540 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/input/serio/i8042.c: In function 'i8042_pm_suspend':
>> drivers/input/serio/i8042.c:1174:6: error: implicit declaration of function 'pm_suspend_via_firmware' [-Werror=implicit-function-declaration]
     if (pm_suspend_via_firmware())
         ^
   drivers/input/serio/i8042.c: In function 'i8042_pm_resume_noirq':
>> drivers/input/serio/i8042.c:1190:7: error: implicit declaration of function 'pm_resume_via_firmware' [-Werror=implicit-function-declaration]
     if (!pm_resume_via_firmware())
          ^
   cc1: some warnings being treated as errors

vim +/pm_suspend_via_firmware +1174 drivers/input/serio/i8042.c

  1168	 */
  1169	
  1170	static int i8042_pm_suspend(struct device *dev)
  1171	{
  1172		int i;
  1173	
> 1174		if (pm_suspend_via_firmware())
  1175			i8042_controller_reset(true);
  1176	
  1177		/* Set up serio interrupts for system wakeup. */
  1178		for (i = 0; i < I8042_NUM_PORTS; i++) {
  1179			struct serio *serio = i8042_ports[i].serio;
  1180	
  1181			if (serio && device_may_wakeup(&serio->dev))
  1182				enable_irq_wake(i8042_ports[i].irq);
  1183		}
  1184	
  1185		return 0;
  1186	}
  1187	
  1188	static int i8042_pm_resume_noirq(struct device *dev)
  1189	{
> 1190		if (!pm_resume_via_firmware())
  1191			i8042_interrupt(0, NULL);
  1192	
  1193		return 0;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [RFC][PATCH v3 3/3] input: i8042: Avoid resetting controller on  system suspend/resume Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-10-07 00:40 +0200
  Re: [RFC][PATCH v3 3/3] input: i8042: Avoid resetting controller on system suspend/resume "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-10-07 00:50 +0200
    Re: [RFC][PATCH v3 3/3] input: i8042: Avoid resetting controller on  system suspend/resume Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-10-07 00:50 +0200
      Re: [RFC][PATCH v3 3/3] input: i8042: Avoid resetting controller on system suspend/resume "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-10-07 01:10 +0200
        Re: Re: [RFC][PATCH v3 3/3] input: i8042: Avoid resetting controller  on system suspend/resume kbuild test robot <lkp@intel.com> - 2015-10-07 01:20 +0200
        Re: [RFC][PATCH v3 3/3] input: i8042: Avoid resetting controller on  system suspend/resume Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-10-07 01:30 +0200
          Re: [RFC][PATCH v3 3/3] input: i8042: Avoid resetting controller on  system suspend/resume "Rafael J. Wysocki" <rafael@kernel.org> - 2015-10-07 01:50 +0200

csiph-web