Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1241021

[PATCH] mlxsw: fix warnings for big-endian 32-bit dma_addr_t

Show all headers | View raw

The recently added mlxsw driver produces warnings in ARM
allmodconfig:

drivers/net/ethernet/mellanox/mlxsw/pci.c: In function 'mlxsw_pci_cmd_exec':
drivers/net/ethernet/mellanox/mlxsw/pci.c:1585:59: warning: right shift count >= width of type [-Wshift-count-overflow]
linux/byteorder/big_endian.h:38:51: note: in definition of macro '__cpu_to_be32'
drivers/net/ethernet/mellanox/mlxsw/pci.c:76:2: note: in expansion of macro 'iowrite32be'

This changes the type of the local variable to u64, which gets rid of the
warning and seems nicer than adding #ifdefs.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: eda6500a987a "mlxsw: Add PCI bus implementation"

diff --git a/drivers/net/ethernet/mellanox/mlxsw/pci.c b/drivers/net/ethernet/mellanox/mlxsw/pci.c
index 462cea31ecbb..cd11e3591741 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/pci.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/pci.c
@@ -1567,8 +1567,8 @@ static int mlxsw_pci_cmd_exec(void *bus_priv, u16 opcode, u8 opcode_mod,
 			      u8 *p_status)
 {
 	struct mlxsw_pci *mlxsw_pci = bus_priv;
-	dma_addr_t in_mapaddr = mlxsw_pci->cmd.in_mbox.mapaddr;
-	dma_addr_t out_mapaddr = mlxsw_pci->cmd.out_mbox.mapaddr;
+	u64 in_mapaddr = mlxsw_pci->cmd.in_mbox.mapaddr;
+	u64 out_mapaddr = mlxsw_pci->cmd.out_mbox.mapaddr;
 	bool evreq = mlxsw_pci->cmd.nopoll;
 	unsigned long timeout = msecs_to_jiffies(MLXSW_PCI_CIR_TIMEOUT_MSECS);
 	bool *p_wait_done = &mlxsw_pci->cmd.wait_done;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] mlxsw: fix warnings for big-endian 32-bit dma_addr_t Arnd Bergmann <arnd@arndb.de> - 2015-10-06 23:50 +0200
  Re: [PATCH] mlxsw: fix warnings for big-endian 32-bit dma_addr_t Jiri Pirko <jiri@resnulli.us> - 2015-10-07 08:50 +0200
  Re: [PATCH] mlxsw: fix warnings for big-endian 32-bit dma_addr_t Joe Perches <joe@perches.com> - 2015-10-07 09:00 +0200
    [PATCH v2] mlxsw: fix warnings for big-endian 32-bit dma_addr_t Arnd Bergmann <arnd@arndb.de> - 2015-10-07 09:00 +0200
      Re: [PATCH v2] mlxsw: fix warnings for big-endian 32-bit dma_addr_t Jiri Pirko <jiri@resnulli.us> - 2015-10-07 09:10 +0200
      Re: [PATCH v2] mlxsw: fix warnings for big-endian 32-bit dma_addr_t David Miller <davem@davemloft.net> - 2015-10-08 14:00 +0200
    Re: [PATCH] mlxsw: fix warnings for big-endian 32-bit dma_addr_t Jiri Pirko <jiri@resnulli.us> - 2015-10-07 09:00 +0200

csiph-web