[PATCHv3 0/1] Update SCSI hosts to use idr for host number mgmt

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Lee Duncan <lduncan@suse.com>
Newsgroups	linux.kernel
Subject	[PATCHv3 0/1] Update SCSI hosts to use idr for host number mgmt
Date	Tue, 06 Oct 2015 21:10:01 +0200
Message-ID	<qgFMB-6Ge-7@gated-at.bofh.it> (permalink)
X-Original-To	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
X-Mailer	git-send-email 2.1.4
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	34
Organization	linux.* mail to news gateway
X-Original-Cc	Lee Duncan <lduncan@suse.com>, James Bottomley <James.Bottomley@HansenPartnership.com>, Tejun Heo <tj@kernel.org>, Hannes Reinecke <hare@suse.com>, Johannes Thumshirn <jthumshirn@suse.de>, Christoph Hellwig <hch@infradead.org>
X-Original-Date	Tue, 6 Oct 2015 12:08:19 -0700
X-Original-Message-ID	<cover.1444157464.git.lduncan@suse.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1240861

Show key headers only | View raw

This patch updates the SCSI hosts module to use the idr
index-management routines to manage its host_no index instead
of using an ATOMIC integer. This means that host numbers
can now be reclaimed and re-used.

It also updates the hosts module to use the idr routine idr_find()
to lookup hosts based on the host number, hopefully speeding
up said lookup.

After noticing that my idr calling sequences where very close
to those in other modules, I considered creating some idr helper
functions (and using them), but because idr usage almost always
requires the caller to manage their own locks, I gave up on
this approach (as suggested by Tejon -- thank you).

Changes from v1:
 - no longer using helper routines
Changes from v2:
 - added back missing scsi_host_get() in scsi_host_lookup()

Lee Duncan (1):
  SCSI: update hosts module to use idr index management

 drivers/scsi/hosts.c | 61 ++++++++++++++++++++++++++--------------------------
 1 file changed, 31 insertions(+), 30 deletions(-)

-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCHv3 0/1] Update SCSI hosts to use idr for host number mgmt Lee Duncan <lduncan@suse.com> - 2015-10-06 21:10 +0200
  [PATCHv3 1/1] SCSI: update hosts module to use idr index management Lee Duncan <lduncan@suse.com> - 2015-10-06 21:10 +0200
    Re: [PATCHv3 1/1] SCSI: update hosts module to use idr index  management James Bottomley <James.Bottomley@HansenPartnership.com> - 2015-10-06 21:30 +0200
      Re: [PATCHv3 1/1] SCSI: update hosts module to use idr index  management Lee Duncan <lduncan@suse.com> - 2015-10-06 23:50 +0200
  Re: [PATCHv3 0/1] Update SCSI hosts to use idr for host number mgmt Lee Duncan <lduncan@suse.com> - 2015-10-08 02:00 +0200

csiph-web