Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1239356

Re: [PATCH v2 1/4] dt-bindings: add sunxi SPDIF transceiver bindings

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Oct 02, 2015 at 07:24:20AM +0200, Code Kipper wrote:
> >> +
> >> +  - compatible               : should be one of the following:
> >> +    - "allwinner,sun4i-a10-spdif": for the Allwinner A10 SoC
> >> +    - "allwinner,sun7i-a20-spdif": for the Allwinner A20 SoC
> >> +    - "allwinner,sun6i-a31-spdif": for the Allwinner A31 SoC
> >
> > Are all these compatibles really work? Is there any significant
> > difference between the controller on all these SoCs?
>
> Let us assume that there isn't any difference. Remember SPDIF details
> for all of these devices is sketchy. In the A10 User Manual, it's not
> even mentioned although devices such as the Mele A2000 which I use
> come with the physical connector. It's only when the A20 Manual was
> released that we see the pin details and related components. We didn't
> see a SPDIF block spec until the H3 User Manual was released.
> 
> Looking at the SDK code I've only seen fifo level settings to be
> different for the sun6i family. It was this release that also showed
> Rx rotines. The fact of the matter is we won't know until these SoCs
> have been tested and with that in mind I'm happy to remove all
> capabilities for now until then.

The point was more that you document compatibles that you are not
actually supporting.

You've only tested it on one SoC (and it actually works only on one
SoC, or at least with one compatible), so only document that.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/4] Add SPDIF support for Allwinner SoCs codekipper@gmail.com - 2015-09-30 20:00 +0200
  [PATCH v2 3/4] ASoC: sunxi: Add S/PDIF machine driver. codekipper@gmail.com - 2015-09-30 20:00 +0200
  [PATCH v2 1/4] dt-bindings: add sunxi SPDIF transceiver bindings codekipper@gmail.com - 2015-09-30 20:00 +0200
    Re: [PATCH v2 1/4] dt-bindings: add sunxi SPDIF transceiver bindings Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-10-01 22:50 +0200
      Re: [PATCH v2 1/4] dt-bindings: add sunxi SPDIF transceiver bindings Code Kipper <codekipper@gmail.com> - 2015-10-02 07:30 +0200
        Re: [PATCH v2 1/4] dt-bindings: add sunxi SPDIF transceiver bindings Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-10-05 10:50 +0200
          Re: [PATCH v2 1/4] dt-bindings: add sunxi SPDIF transceiver bindings Code Kipper <codekipper@gmail.com> - 2015-10-05 12:50 +0200
  [PATCH v2 4/4] ASOC: sunxi: Add support for the spdif block codekipper@gmail.com - 2015-09-30 20:00 +0200
    [PATCH] ASOC: sunxi: fix platform_no_drv_owner.cocci warnings kbuild test robot <lkp@intel.com> - 2015-09-30 20:30 +0200
    Re: [PATCH v2 4/4] ASOC: sunxi: Add support for the spdif block kbuild test robot <lkp@intel.com> - 2015-09-30 20:30 +0200
    [RFC PATCH] ASOC: sunxi: sun4i_snd_txctrl_on() can be static kbuild test robot <lkp@intel.com> - 2015-09-30 21:00 +0200
    Re: [PATCH v2 4/4] ASOC: sunxi: Add support for the spdif block kbuild test robot <lkp@intel.com> - 2015-09-30 21:00 +0200
    Re: [PATCH v2 4/4] ASOC: sunxi: Add support for the spdif block Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-10-01 22:50 +0200
      Re: [PATCH v2 4/4] ASOC: sunxi: Add support for the spdif block Code Kipper <codekipper@gmail.com> - 2015-10-02 08:50 +0200

csiph-web