Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1238877

[PATCH 11/24] ver_linux: xfsprogs.patch

Path csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From Alexander Kapshuk <alexander.kapshuk@gmail.com>
Newsgroups linux.kernel
Subject [PATCH 11/24] ver_linux: xfsprogs.patch
Date Sat, 03 Oct 2015 15:40:01 +0200
Message-ID <qfvcB-3eS-5@gated-at.bofh.it> (permalink)
X-Original-To linux-kernel <linux-kernel@vger.kernel.org>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to:cc:content-type; bh=KCA6UgR1R9rvPfCPeBZCym8quUvUEvoJ8QDxhqUz6Yo=; b=fW/D+1N3HfCAls7hm/n29r4FUeQWCThwDXcF1FMMM7nqmsc9vUX8bLpyl4yn58y09T tEkyMCIy1qjCx8jtxOpvSQdERGnDh9LyKAOhnzsQTfQTrel+QhGinalG+cfrRpj5CHmX Q6JiiGF4rE7rnGlk3FghTOH6ZpiT4Joby7pl+LEMfk7mF0nFSM+6GOHGV98ef6Ugbc8o cPR1VjhdBtBwPkeKh87aumduRHWzAE5ntFMR4FXqp3i0SFeuc810UkgRbV2RVx1d/Ri+ D/yLj8x1smEJxfyuDzd9KLXQ0HmvgU3vloru3l2tbwoghSw09hByPwcFrnkK4Lkik2+L av7Q==
X-Received by 10.25.143.73 with SMTP id r70mr5014397lfd.108.1443879198457; Sat, 03 Oct 2015 06:33:18 -0700 (PDT)
MIME-Version 1.0
Content-Type text/plain; charset=UTF-8
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 39
Organization linux.* mail to news gateway
X-Original-Cc Greg KH <gregkh@linuxfoundation.org>
X-Original-Date Sat, 3 Oct 2015 16:32:38 +0300
X-Original-Message-ID <CAJ1xhMXNHHa7Zyr0ZHZ62sYi4eZ+qMpO4d7npKpnGMKcwQYP+A@mail.gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1238877

Show key headers only | View raw


The current implementation uses both 'grep' and 'awk' for text processing
here, which may be allright as a quick solution to be run on the command
line. While in a script, 'sed' or 'awk' would be a better choice. On
top of that, the current implementation expects the version number to
be found in the last field as seen by 'awk'. Should the output format
be different, this approach would no longer be reliable.

The proposed implementation uses 'sed' as a more flexible tool to handle
varying output formats.

Tested on:
Arch Linux


Signed-off-by: Alexander Kapshuk <alexander.kapshuk@gmail.com>
---
--- linux/scripts/ver_linux.orig    2015-10-03 13:41:57.118790241 +0300
+++ linux/scripts/ver_linux    2015-10-03 13:54:03.057927175 +0300
@@ -39,8 +39,13 @@
 fsck.reiser4 -V 2>&1 | grep ^fsck.reiser4 | awk \
 'NR==1{print "reiser4progs          ", $2}'

-xfs_db -V 2>&1 | grep version | awk \
-'NR==1{print "xfsprogs              ", $3}'
+test -x "$xfs_db" &&
+$xfs_db -V 2>&1 |
+sed '
+    /version/!d
+    s/[^0-9\.]//g
+    s/^/xfsprogs\t\t/
+'

 pccardctl -V 2>&1| grep pcmciautils | awk '{print "pcmciautils
   ", $2}'
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH 11/24] ver_linux: xfsprogs.patch Alexander Kapshuk <alexander.kapshuk@gmail.com> - 2015-10-03 15:40 +0200

csiph-web