Re: [PATCH v4 17/26] ARM: pxa: magician: Fix wrongly enabled USB host ports

From	Philipp Zabel <philipp.zabel@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 17/26] ARM: pxa: magician: Fix wrongly enabled USB host ports
Date	2015-10-03 14:50 +0200
Message-ID	<qfuqd-251-5@gated-at.bofh.it> (permalink)
References	<qdO02-2Tc-11@gated-at.bofh.it> <qdOjn-3fZ-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Am Montag, den 28.09.2015, 23:38 +0200 schrieb Petr Cvek:
> USB host ports on the HTC Magician are wrongly enabled. Port 1 is for
> bluetooth and port 2 is for OTG (mux in the charger connector).
> 
> Signed-off-by: Petr Cvek <petr.cvek@tul.cz>
> ---
>  arch/arm/mach-pxa/magician.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-pxa/magician.c b/arch/arm/mach
> -pxa/magician.c
> index 8e8b122..af8133a 100644
> --- a/arch/arm/mach-pxa/magician.c
> +++ b/arch/arm/mach-pxa/magician.c
> @@ -780,8 +780,10 @@ static struct pxamci_platform_data
> magician_mci_info = {
>  
>  static struct pxaohci_platform_data magician_ohci_info = {
>  	.port_mode	= PMM_PERPORT_MODE,
> -	.flags		= ENABLE_PORT1 | ENABLE_PORT3 |
> POWER_CONTROL_LOW,
> +	/* port1: CSR Bluetooth, port2: OTG with UDC */
> +	.flags		= ENABLE_PORT1 | ENABLE_PORT2 |
> POWER_CONTROL_LOW,
>  	.power_budget	= 0,
> +	.power_on_delay = 100,
>  };

I have only ever tested the CSR bluetooth chip, so this could be
correct, or again something that is different between the magician
variants. I don't know.

regards
Philipp
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v4 17/26] ARM: pxa: magician: Fix wrongly enabled USB host  ports Petr Cvek <petr.cvek@tul.cz> - 2015-09-28 23:40 +0200
  Re: [PATCH v4 17/26] ARM: pxa: magician: Fix wrongly enabled USB  host ports Philipp Zabel <philipp.zabel@gmail.com> - 2015-10-03 14:50 +0200
    Re: [PATCH v4 17/26] ARM: pxa: magician: Fix wrongly enabled USB host  ports Petr Cvek <petr.cvek@tul.cz> - 2015-10-05 04:10 +0200

csiph-web