Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1238859

[PATCH 3/24] ver_linux: gcc.patch

Show all headers | View raw

Using 'awk' here is a bit of an overkill. Should the output of 'gcc
-dumpversion' vary on another disto, or change overtime, it may no longer
be available at field 1, as relied on by the current implementation.
I believe 'sed' offers greater flexibility here in terms of processing
varying output as well as being more light-weight.

Tested on:
Gentoo Linux
Debian 6.0.10
Oracle Linux Server release 7.1
Arch Linux
openSuSE 13.2

Signed-off-by: Alexander Kapshuk <alexander.kapshuk@gmail.com>
---
--- linux/scripts/ver_linux.orig    2015-10-03 13:41:57.118790241 +0300
+++ linux/scripts/ver_linux    2015-10-03 13:48:49.277622632 +0300
@@ -11,8 +11,12 @@
 uname -a
 echo ' '

-gcc -dumpversion 2>&1| awk \
-'NR==1{print "Gnu C                 ", $1}'
+test -x "$gcc" &&
+$gcc -dumpversion 2>&1 |
+sed '
+    /^[0-9\.]*$/!d
+    s/^/GNU C\t\t\t/
+'

 make --version 2>&1 | awk -F, '{print $1}' | awk \
       '/GNU Make/{print "Gnu make              ",$NF}'
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/24] ver_linux: gcc.patch Alexander Kapshuk <alexander.kapshuk@gmail.com> - 2015-10-03 15:10 +0200
  Re: [PATCH 3/24] ver_linux: gcc.patch Richard Weinberger <richard.weinberger@gmail.com> - 2015-10-03 17:10 +0200
    Re: [PATCH 3/24] ver_linux: gcc.patch Alexander Kapshuk <alexander.kapshuk@gmail.com> - 2015-10-03 18:10 +0200
      Re: [PATCH 3/24] ver_linux: gcc.patch Richard Weinberger <richard@nod.at> - 2015-10-03 18:30 +0200

csiph-web