Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1238761

[tip:perf/core] perf callchain: Allow for max_stack greater than PERF_MAX_STACK_DEPTH

Show all headers | View raw

Commit-ID:  0edd453368c6b9cdb756bde2b6675bb0d5d0eb0a
Gitweb:     http://git.kernel.org/tip/0edd453368c6b9cdb756bde2b6675bb0d5d0eb0a
Author:     Adrian Hunter <adrian.hunter@intel.com>
AuthorDate: Fri, 25 Sep 2015 16:15:48 +0300
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 1 Oct 2015 09:56:06 -0300

perf callchain: Allow for max_stack greater than PERF_MAX_STACK_DEPTH

Adjust the validation to allow for max_stack greater than
PERF_MAX_STACK_DEPTH.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Link: http://lkml.kernel.org/r/1443186956-18718-18-git-send-email-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/machine.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
index 76fe167..5ef90be 100644
--- a/tools/perf/util/machine.c
+++ b/tools/perf/util/machine.c
@@ -1831,7 +1831,7 @@ static int thread__resolve_callchain_sample(struct thread *thread,
 	}
 
 check_calls:
-	if (chain->nr > PERF_MAX_STACK_DEPTH) {
+	if (chain->nr > PERF_MAX_STACK_DEPTH && (int)chain->nr > max_stack) {
 		pr_warning("corrupted callchain. skipping...\n");
 		return 0;
 	}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 17/25] perf callchain: Allow for max_stack greater than PERF_MAX_STACK_DEPTH Adrian Hunter <adrian.hunter@intel.com> - 2015-09-25 15:30 +0200
  Re: [PATCH 17/25] perf callchain: Allow for max_stack greater than  PERF_MAX_STACK_DEPTH Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-09-28 22:10 +0200
    Re: [PATCH 17/25] perf callchain: Allow for max_stack greater than  PERF_MAX_STACK_DEPTH Adrian Hunter <adrian.hunter@intel.com> - 2015-09-29 10:20 +0200
      Re: [PATCH 17/25] perf callchain: Allow for max_stack greater than  PERF_MAX_STACK_DEPTH Adrian Hunter <adrian.hunter@intel.com> - 2015-10-01 13:50 +0200
  [tip:perf/core] perf callchain:   Allow for max_stack greater than PERF_MAX_STACK_DEPTH tip-bot for Adrian Hunter <tipbot@zytor.com> - 2015-10-03 10:00 +0200

csiph-web