Re: [PATCH v4 3/5] PCI: Handle IORESOURCE_PCI_FIXED when sizing and assigning resources.

From	Yinghai Lu <yinghai@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 3/5] PCI: Handle IORESOURCE_PCI_FIXED when sizing and assigning resources.
Date	2015-10-03 05:10 +0200
Message-ID	<qflmV-6d8-1@gated-at.bofh.it> (permalink)
References	<qfh9E-8tG-13@gated-at.bofh.it> <qfh9E-8tG-19@gated-at.bofh.it> <qfhMm-10f-13@gated-at.bofh.it> <qflmV-6d8-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Oct 2, 2015 at 4:38 PM, David Daney <ddaney@caviumnetworks.com> wrote:
> On 10/02/2015 04:14 PM, Yinghai Lu wrote:
>>
>> https://patchwork.kernel.org/patch/7304371/
>> [v6,06/53] PCI: Claim fixed resource during remove/rescan path
>
>
> This one is interesting, but I don't think it will work.
>
> pci_claim_resource() calls pci_find_parent_resource(), which will fail in
> important use cases.
>
> It is perfectly legal for a bridge provisioned by EA to not specify any
> resources.  In this case we must walk up the bus tree until we find
> something that contains the device resource, and can thus be a parent.
>
> That is a big part of what my patch is doing.

looks we need another resource flags for EA in addition to
FIXED as it could out side of bridge MMIO range.

>
> As for the merits of assigning fixed resources from the FINAL fixup, rather
> than in __pci_bus_assign_resources(), I am unsure.

usually __pci_bus_assign_resources() is used for unassigned one. so
I don't want it mixed with request resource there.

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4 3/5] PCI: Handle IORESOURCE_PCI_FIXED when sizing and assigning resources. David Daney <ddaney.cavm@gmail.com> - 2015-10-03 00:40 +0200
  Re: [PATCH v4 3/5] PCI: Handle IORESOURCE_PCI_FIXED when sizing and  assigning resources. Yinghai Lu <yinghai@kernel.org> - 2015-10-03 01:20 +0200
    Re: [PATCH v4 3/5] PCI: Handle IORESOURCE_PCI_FIXED when sizing and  assigning resources. Yinghai Lu <yinghai@kernel.org> - 2015-10-03 05:10 +0200

csiph-web