Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1238514

Re: [PATCH] clk: ti: dflt: fix enable_reg validity check

Show all headers | View raw

On 09/29, Suman Anna wrote:
> diff --git a/drivers/clk/ti/clkt_dflt.c b/drivers/clk/ti/clkt_dflt.c
> index 90d7d8a21c49..1ddc288fce4e 100644
> --- a/drivers/clk/ti/clkt_dflt.c
> +++ b/drivers/clk/ti/clkt_dflt.c
> @@ -222,7 +222,7 @@ int omap2_dflt_clk_enable(struct clk_hw *hw)
>  		}
>  	}
>  
> -	if (unlikely(!clk->enable_reg)) {
> +	if (unlikely(IS_ERR(clk->enable_reg))) {

IS_ERR() already has an unlikely inside it, so the unlikely is
redundant here.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] clk: ti: dflt: fix enable_reg validity check Suman Anna <s-anna@ti.com> - 2015-09-30 00:40 +0200
  Re: [PATCH] clk: ti: dflt: fix enable_reg validity check Tero Kristo <t-kristo@ti.com> - 2015-10-02 08:40 +0200
  Re: [PATCH] clk: ti: dflt: fix enable_reg validity check Stephen Boyd <sboyd@codeaurora.org> - 2015-10-02 20:30 +0200
    Re: [PATCH] clk: ti: dflt: fix enable_reg validity check Suman Anna <s-anna@ti.com> - 2015-10-02 20:50 +0200

csiph-web