Re: [PATCH 18/18] Input: tps6507x-ts - simplify function return logic

From	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 18/18] Input: tps6507x-ts - simplify function return logic
Date	2015-10-02 20:30 +0200
Message-ID	<qfdfH-2Wl-7@gated-at.bofh.it> (permalink)
References	<qf8SJ-4YE-7@gated-at.bofh.it> <qf8SK-4YE-43@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Oct 02, 2015 at 03:40:29PM +0200, Javier Martinez Canillas wrote:
> The invoked function already returns zero on success or a negative
> errno code so there is no need to open code the logic in the caller.
> 
> This also fixes the following make coccicheck warning:
> 
> drivers/input/touchscreen/tps6507x-ts.c:57:5-8: WARNING: end returns can be simplified
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 

Applied, thank you.

> ---
> 
>  drivers/input/touchscreen/tps6507x-ts.c | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/tps6507x-ts.c b/drivers/input/touchscreen/tps6507x-ts.c
> index 4ffd829d1990..a340bfccdfb6 100644
> --- a/drivers/input/touchscreen/tps6507x-ts.c
> +++ b/drivers/input/touchscreen/tps6507x-ts.c
> @@ -50,14 +50,7 @@ struct tps6507x_ts {
>  
>  static int tps6507x_read_u8(struct tps6507x_ts *tsc, u8 reg, u8 *data)
>  {
> -	int err;
> -
> -	err = tsc->mfd->read_dev(tsc->mfd, reg, 1, data);
> -
> -	if (err)
> -		return err;
> -
> -	return 0;
> +	return tsc->mfd->read_dev(tsc->mfd, reg, 1, data);
>  }
>  
>  static int tps6507x_write_u8(struct tps6507x_ts *tsc, u8 reg, u8 data)
> -- 
> 2.4.3
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 18/18] Input: tps6507x-ts - simplify function return logic Javier Martinez Canillas <javier@osg.samsung.com> - 2015-10-02 15:50 +0200
  Re: [PATCH 18/18] Input: tps6507x-ts - simplify function return logic Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-10-02 20:30 +0200

csiph-web