Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1238536

Re: [PATCH] input: gpio_keys: Make pdev vs dev usage more consistent

Show all headers | View raw

On Fri 02 Oct 10:47 PDT 2015, Dmitry Torokhov wrote:

> On Mon, Jul 27, 2015 at 06:50:18PM -0700, Bjorn Andersson wrote:
> > As gpio_keys_setup_key() only operates on the device, pass a pointer to
> > this from the probe instead of a platform_device and make the usage
> > consistent. Also make probe() more consistent by dropping the local copy
> > of the device pointer.
> > 
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> 
> Don't really see the difference either way... We trade &pdev->dev for
> dev in one place and trade dev for &pdev->dev in another. I'd rather
> skip it.
> 
> Thanks.
> 

No worries, my dislike of the mixing of the two uses within the first
function was enough to hack up a patch - feel free to drop it as you
don't think it's worth the churn.


Thanks for merging the error handling patch though.

Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] input: gpio_keys: Make pdev vs dev usage more consistent Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-10-02 19:50 +0200
  Re: [PATCH] input: gpio_keys: Make pdev vs dev usage more consistent Bjorn Andersson <bjorn.andersson@sonymobile.com> - 2015-10-02 21:10 +0200

csiph-web