Re: [PATCH 04/14] RFC: usb/host/fotg210: Remove NULL checks dma_pool_destroy

From	Felipe Balbi <balbi@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 04/14] RFC: usb/host/fotg210: Remove NULL checks dma_pool_destroy
Date	2015-10-02 19:40 +0200
Message-ID	<qfctl-1MB-37@gated-at.bofh.it> (permalink)
References	<q91Kj-2gb-19@gated-at.bofh.it> <qbaT7-1N0-3@gated-at.bofh.it> <qbaT8-1N0-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Sep 21, 2015 at 05:01:08PM +0200, Peter Senna Tschudin wrote:
> This patch remove NULL checks before calls to dma_pool_destroy() as the
> function now can handle NULL pointers.
> 
> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>

looks good to me

> ---
>  drivers/usb/host/fotg210-hcd.c | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c
> index f574143..51feb61 100644
> --- a/drivers/usb/host/fotg210-hcd.c
> +++ b/drivers/usb/host/fotg210-hcd.c
> @@ -1925,17 +1925,13 @@ static void fotg210_mem_cleanup(struct fotg210_hcd *fotg210)
>  	fotg210->dummy = NULL;
>  
>  	/* DMA consistent memory and pools */
> -	if (fotg210->qtd_pool)
> -		dma_pool_destroy(fotg210->qtd_pool);
> +	dma_pool_destroy(fotg210->qtd_pool);
>  	fotg210->qtd_pool = NULL;
>  
> -	if (fotg210->qh_pool) {
> -		dma_pool_destroy(fotg210->qh_pool);
> -		fotg210->qh_pool = NULL;
> -	}
> +	dma_pool_destroy(fotg210->qh_pool);
> +	fotg210->qh_pool = NULL;
>  
> -	if (fotg210->itd_pool)
> -		dma_pool_destroy(fotg210->itd_pool);
> +	dma_pool_destroy(fotg210->itd_pool);
>  	fotg210->itd_pool = NULL;
>  
>  	if (fotg210->periodic)
> -- 
> 2.1.0
> 

-- 
balbi

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 04/14] RFC: usb/host/fotg210: Remove NULL checks  dma_pool_destroy Felipe Balbi <balbi@ti.com> - 2015-10-02 19:40 +0200

csiph-web