Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1238410

Re: [PATCH 1/1] perf,stat: reduce interval-print to 10ms

Show all headers | View raw

On Fri, Oct 02, 2015 at 05:04:34AM -0400, kan.liang@intel.com wrote:
> From: Kan Liang <kan.liang@intel.com>
> 

SNIP

> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> index a96fb5c..5ef88f7 100644
> --- a/tools/perf/builtin-stat.c
> +++ b/tools/perf/builtin-stat.c
> @@ -1179,7 +1179,7 @@ int cmd_stat(int argc, const char **argv, const char *prefix __maybe_unused)
>  	OPT_STRING(0, "post", &post_cmd, "command",
>  			"command to run after to the measured command"),
>  	OPT_UINTEGER('I', "interval-print", &stat_config.interval,
> -		    "print counts at regular interval in ms (>= 100)"),
> +		    "print counts at regular interval in ms (>= 10)"),
>  	OPT_SET_UINT(0, "per-socket", &stat_config.aggr_mode,
>  		     "aggregate counts per processor socket", AGGR_SOCKET),
>  	OPT_SET_UINT(0, "per-core", &stat_config.aggr_mode,
> @@ -1332,9 +1332,14 @@ int cmd_stat(int argc, const char **argv, const char *prefix __maybe_unused)
>  		thread_map__read_comms(evsel_list->threads);
>  
>  	if (interval && interval < 100) {
> -		pr_err("print interval must be >= 100ms\n");
> -		parse_options_usage(stat_usage, options, "I", 1);
> -		goto out;
> +		if (interval < 10) {
> +			pr_err("print interval must be >= 10ms\n");
> +			parse_options_usage(stat_usage, options, "I", 1);
> +			goto out;
> +		} else
> +			pr_warning("print interval < 100ms. "
> +				   "The overhead percentage could be high in some cases. "
> +				   "Please proceed with caution.\n");

with '-I' 10 this warning flies away quite fast ;-)

I guess it's better than nothing, and I'm not sure
about putting some sleep after that warning..

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] perf,stat: reduce interval-print to 10ms kan.liang@intel.com - 2015-10-02 18:30 +0200
  Re: [PATCH 1/1] perf,stat: reduce interval-print to 10ms Jiri Olsa <jolsa@redhat.com> - 2015-10-02 19:00 +0200
    Re: [PATCH 1/1] perf,stat: reduce interval-print to 10ms Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-02 22:10 +0200
      RE: [PATCH 1/1] perf,stat: reduce interval-print to 10ms "Liang, Kan" <kan.liang@intel.com> - 2015-10-02 22:30 +0200
        Re: [PATCH 1/1] perf,stat: reduce interval-print to 10ms Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-02 22:50 +0200
          RE: [PATCH 1/1] perf,stat: reduce interval-print to 10ms "Liang, Kan" <kan.liang@intel.com> - 2015-10-02 23:00 +0200
  [tip:perf/core] perf stat: Reduce min --interval-print to 10ms tip-bot for Kan Liang <tipbot@zytor.com> - 2015-10-03 10:00 +0200

csiph-web