Re: [PATCH 16/18] Input: elan_i2c - simplify function return logic

From	Benson Leung <bleung@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 16/18] Input: elan_i2c - simplify function return logic
Date	2015-10-02 18:50 +0200
Message-ID	<qfbGV-zx-7@gated-at.bofh.it> (permalink)
References	<qf8SJ-4YE-7@gated-at.bofh.it> <qf8SK-4YE-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Oct 2, 2015 at 6:40 AM, Javier Martinez Canillas
<javier@osg.samsung.com> wrote:
> The invoked function already returns zero on success or a negative
> errno code so there is no need to open code the logic in the caller.
>
> This also fixes the following make coccicheck warning:
>
> drivers/input/mouse/elan_i2c_smbus.c:402:1-6: WARNING: end returns can be simplified
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

Reviewed-by: Benson Leung <bleung@chromium.org>


-- 
Benson Leung
Software Engineer, Chrom* OS
bleung@chromium.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 16/18] Input: elan_i2c - simplify function return logic Javier Martinez Canillas <javier@osg.samsung.com> - 2015-10-02 15:50 +0200
  Re: [PATCH 16/18] Input: elan_i2c - simplify function return logic Benson Leung <bleung@chromium.org> - 2015-10-02 18:50 +0200

csiph-web