Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1239196

Re: [PATCH] staging: rtl8723au: Fix Sparse errors in rtl8723a_cmd.c

Show all headers | View raw

Hi Greg,

Thanks for the response! It's always good to get notes on a patch.
Some responses to your points:

> Why __le32?  Does this variable go across the user/kernel boundry
> somehow?  If not, just use le32.

Good point, this should probably have been le32.

> At first glance, you aren't doing ths same logic in this function as the
> original did, please look at this very closely again and verify that you
> are doing this correctly.
>
> Don't just blindly quiet tools like sparse, it is warning for a reason,
> but be careful about your fix.

On a second, closer look at the code I am not doing this correctly: the
buffer I am converting to le32 needs to persist (which a local variable
would not). On my first glance at this code I saw the same buffer being
used for both little- and big-endian storage of the same data -- it's
correct, but a little ugly.

I am going to leave this code as is, since it was functioning properly
before my patch.

Thanks,
Jake
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: rtl8723au: Fix Sparse errors in rtl8723a_cmd.c Jacob Kiefer <jtk54@cornell.edu> - 2015-10-03 02:40 +0200
  Re: [PATCH] staging: rtl8723au: Fix Sparse errors in rtl8723a_cmd.c Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-10-04 10:50 +0200
  Re: [PATCH] staging: rtl8723au: Fix Sparse errors in rtl8723a_cmd.c Jacob Kiefer <jtk54@cornell.edu> - 2015-10-04 21:50 +0200

csiph-web