Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1239187

Re: [PATCH 1/4] firmware: generalize "firmware" as "system data" helpers

From Greg KH <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH 1/4] firmware: generalize "firmware" as "system data" helpers
Date 2015-10-04 21:20 +0200
Message-ID <qfWZb-Zo-9@gated-at.bofh.it> (permalink)
References <pTSzg-70T-9@gated-at.bofh.it> <pTSzh-70T-41@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Aug 04, 2015 at 03:00:01PM -0700, Luis R. Rodriguez wrote:
> From: "Luis R. Rodriguez" <mcgrof@suse.com>
> 
> Historically firmware_class code was added to help
> get device driver firmware binaries but these days
> request_firmware*() helpers are being repurposed for
> general system data needed by the kernel.
> 
> Annotate this before we extend firmare_class more,
> as this is expected. We want to generalize the code
> as much as possible.

No, let's leave this as "firmware", as that is what the code does.

If you want to create a "load a resource from the filesystem into the
kernel" subsystem, then let's do that and then port the firmware loader
code over to use that api.

But until then, let's not try to morph the firmware code into something
that it really is not at all at the moment, just because it looks like
this might be a nice thing to do someday in the future.

sorry,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

Re: [PATCH 1/4] firmware: generalize "firmware" as "system data"  helpers Greg KH <gregkh@linuxfoundation.org> - 2015-10-04 21:20 +0200
  Re: [PATCH 1/4] firmware: generalize "firmware" as "system data"  helpers "Luis R. Rodriguez" <mcgrof@suse.com> - 2015-10-05 23:30 +0200

csiph-web