Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1239162

[PATCH v3 3/7] jffs2: Add missing capability check for listing trusted xattrs

Show all headers | View raw

The vfs checks if a task has the appropriate access for get and set
operations, but it cannot do that for the list operation; the file system
must check for that itself.

Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: linux-mtd@lists.infradead.org
---
 fs/jffs2/xattr_trusted.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/fs/jffs2/xattr_trusted.c b/fs/jffs2/xattr_trusted.c
index ceaf9c6..bbd20c1 100644
--- a/fs/jffs2/xattr_trusted.c
+++ b/fs/jffs2/xattr_trusted.c
@@ -39,6 +39,9 @@ static size_t jffs2_trusted_listxattr(struct dentry *dentry, char *list,
 {
 	size_t retlen = XATTR_TRUSTED_PREFIX_LEN + name_len + 1;
 
+	if (!capable(CAP_SYS_ADMIN))
+		return 0;
+
 	if (list && retlen<=list_size) {
 		strcpy(list, XATTR_TRUSTED_PREFIX);
 		strcpy(list + XATTR_TRUSTED_PREFIX_LEN, name);
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/7] Pass xattr handler to xattr handler operations Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-04 19:30 +0200
  [PATCH v3 3/7] jffs2: Add missing capability check for listing trusted xattrs Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-04 19:30 +0200
  [PATCH v3 7/7] f2fs: xattr simplifications Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-04 19:30 +0200
  [PATCH v3 5/7] 9p: xattr simplifications Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-04 19:30 +0200
  [PATCH v3 1/7] ubifs: Remove unused security xattr handler Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-04 19:30 +0200
  [PATCH v3 2/7] hfsplus: Remove unused xattr handler list operations Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-04 19:30 +0200

csiph-web