Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1239147

Re: [PATCH 1/24] ver_linux: echo.patch

Show all headers | View raw

Your subject is really "odd", it doesn't really describe what you are
doing in a single line, it just has a file name in it :(

What did you use to generate these?  I got a few duplicates, and there
isn't a "leading" 0 for the first 9 patches.  git can spit these out
correctly very simply, I recommend using that in the future.

On Sat, Oct 03, 2015 at 03:57:08PM +0300, Alexander Kapshuk wrote:
> While not a problem in itself, I was not sure why 'echo space' was used.
> Not being aware of any immediate benefits to this, I thought using
> 'echo' by itself would suffice in printing a newline, which I believe is
> the desired behaviour.
> 
> Signed-off-by: Alexander Kapshuk <alexander.kapshuk@gmail.com>
> ---
> --- linux/scripts/ver_linux.orig    2015-10-03 13:41:57.118790241 +0300
> +++ linux/scripts/ver_linux    2015-10-03 13:43:38.587271851 +0300
> @@ -6,10 +6,10 @@
>  #
>  echo 'If some fields are empty or look unusual you may have an old version.'
>  echo 'Compare to the current minimal requirements in Documentation/Changes.'
> -echo ' '
> +echo
> 
>  uname -a
> -echo ' '
> +echo

Can you respin these patches with correct subject lines, based on this,
and the other feedback you have gotten and resend them?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/24] ver_linux: echo.patch Alexander Kapshuk <alexander.kapshuk@gmail.com> - 2015-10-03 15:00 +0200
  Re: [PATCH 1/24] ver_linux: echo.patch Greg KH <gregkh@linuxfoundation.org> - 2015-10-04 18:20 +0200

csiph-web