Re: [char-misc 1/2 4.3 V2] mei: Fix debugfs filename in error output

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [char-misc 1/2 4.3 V2] mei: Fix debugfs filename in error output
Date	2015-10-04 13:20 +0200
Message-ID	<qfPuF-7an-1@gated-at.bofh.it> (permalink)
References	<qb4b0-nG-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Sep 21, 2015 at 10:58:15AM +0300, Tomas Winkler wrote:
> From: Alexander Kuleshov <kuleshovmail@gmail.com>
> 
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> ---
> V2: fixed author address
> 
>  drivers/misc/mei/debugfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/mei/debugfs.c b/drivers/misc/mei/debugfs.c
> index 4b469cf9e60f..c157f0ba575c 100644
> --- a/drivers/misc/mei/debugfs.c
> +++ b/drivers/misc/mei/debugfs.c
> @@ -213,7 +213,7 @@ int mei_dbgfs_register(struct mei_device *dev, const char *name)
>  	f = debugfs_create_file("active", S_IRUSR, dir,
>  				dev, &mei_dbgfs_fops_active);
>  	if (!f) {
> -		dev_err(dev->dev, "meclients: registration failed\n");
> +		dev_err(dev->dev, "active: registration failed\n");
>  		goto err;

You should never care if a debugfs call fails or not.  Also, this will
"fail" if you don't have CONFIG_DEBUGFS enabled, which means you are
using the api wrong :(

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [char-misc 1/2 4.3 V2] mei: Fix debugfs filename in error output Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-10-04 13:20 +0200
  RE: [char-misc 1/2 4.3 V2] mei: Fix debugfs filename in error output "Winkler, Tomas" <tomas.winkler@intel.com> - 2015-10-05 16:50 +0200
    Re: [char-misc 1/2 4.3 V2] mei: Fix debugfs filename in error output Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-10-05 17:40 +0200

csiph-web