Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1239085

Re: [PATCH V5 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

Show all headers | View raw

On Sun, Sep 27, 2015 at 03:48:24PM +0200, Rafael J. Wysocki wrote:
> On Sun, Sep 27, 2015 at 12:04 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > global_lock is defined as an unsigned long and accessing only its lower
> > 32 bits from sysfs is incorrect, as we need to consider other 32 bits
> > for big endian 64-bit systems. There are no such platforms yet, but the
> > code needs to be robust for such a case.
> >
> > Fix that by changing type of 'global_lock' to u32.
> >
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> 
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Greg, please take this one along with the [2/2] if that one looks good to you.

Thanks, will do.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V5 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-27 00:10 +0200
  Re: [PATCH V5 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' "Rafael J. Wysocki" <rafael@kernel.org> - 2015-09-27 15:50 +0200
    Re: [PATCH V5 1/2] ACPI / EC: Fix broken 64bit big-endian users of  'global_lock' Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-10-04 12:00 +0200

csiph-web