Re: [PATCH 06/14] RFC: usb/host/fotg210: replace msleep by usleep_range

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Peter Senna Tschudin <peter.senna@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 06/14] RFC: usb/host/fotg210: replace msleep by usleep_range
Date	Sun, 04 Oct 2015 12:00:01 +0200
Message-ID	<qfOff-5eb-1@gated-at.bofh.it> (permalink)
References	<qfctl-1MB-35@gated-at.bofh.it> <qfcMJ-29a-51@gated-at.bofh.it>
X-Original-To	Alan Stern <stern@rowland.harvard.edu>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=0XBFrn0b5r84hv4zgyK7zIC81kTEaeaFZetzke4ESI8=; b=xm9WJ8Y33K3sLC8pNWnXlZGFp8euqqbzc0LKcanl0PCIMlbcPgIkC46vRbU9mn8qni lp97QN950pRormPblRnmsRuENg4dyRejdmzs9TD8By+wyrE07yqTURkinFZTlZtJtVbN 55wL5dC1LFhH8J/AidXOfaTfdLkmp58BtJw3X/TWZGqnGgB8mMcFzXnWGon86Udqtk7U xqn3BWdc8xlMEgVAB5JAVYmBstsbJH/SxHR2SSZzlveLOCav/BNHWiecpaOp+ZVN+MrG EgbCLCkJg0MvHJTqCpQG2hNY/mzecHeolGImh7Bu/32/dPSfKHasigd5NZrCbJyXq39y I4pQ==
MIME-Version	1.0
X-Received	by 10.181.13.102 with SMTP id ex6mr6158819wid.64.1443952701778; Sun, 04 Oct 2015 02:58:21 -0700 (PDT)
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	60
Organization	linux.* mail to news gateway
X-Original-Cc	Felipe Balbi <balbi@ti.com>, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>, Masanari Iida <standby24x7@gmail.com>, pmladek@suse.cz, linux-usb@vger.kernel.org, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>
X-Original-Date	Sun, 4 Oct 2015 11:58:20 +0200
X-Original-Message-ID	<CA+MoWDrGds17eQcbQhVZDfYyuxY45R5kk5qXw6U+Bu-8SLPxcQ@mail.gmail.com>
X-Original-References	<20151002173113.GQ5552@saruman.tx.rr.com> <Pine.LNX.4.44L0.1510021349220.1805-100000@iolanthe.rowland.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1239083

Show key headers only | View raw

On Fri, Oct 2, 2015 at 7:52 PM, Alan Stern <stern@rowland.harvard.edu> wrote:
> On Fri, 2 Oct 2015, Felipe Balbi wrote:
>
>> On Mon, Sep 21, 2015 at 05:01:10PM +0200, Peter Senna Tschudin wrote:
>> > msleep under 20ms can result in sleeping up to 20ms, which may not be
>> > intended. Replace msleep(5) by usleep_range(5000, 6000).
>> >
>> > Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
>>
>> good catch. I'd apply this straight away. Alan ?
>
> It really doesn't matter.  As long as the delay is at least 5 ms, it
> can be arbitrarily long.  This won't hurt, and if it prevents automated
> tools from complaining then it's worthwhile.
Then is it a good idea to increase the range to reduce chances of
creating an interrupt?

usleep_range(5000, 10000)?

>
> Peter, a lot of the changes you have been making will also apply to the
> ehci-hcd driver.  Do you want to update it as well?  One caution: The
> style used for continuation lines is to add two extra tab stops, not to
> align things with an open paren on the original line.
The drivers with more checkpatch errors and warnings are:

<number of errors> <number of warnings> <path>

117 586 drivers/usb/host/fusbh200-hcd.c
38 124 drivers/usb/host/ohci-q.c
38 122 drivers/usb/host/ehci-dbg.c
37 118 drivers/usb/host/ohci-dbg.c
36 129 drivers/usb/host/ehci-sched.c
24 136 drivers/usb/host/ohci-hcd.c
23 16 drivers/usb/host/sl811-hcd.c
20 105 drivers/usb/host/ohci-hub.c
18 48 drivers/usb/host/ehci-hub.c

17 70 drivers/usb/host/ehci-hcd.c

13 4 drivers/usb/host/uhci-debug.c
12 93 drivers/usb/host/ehci-q.c
9 83 drivers/usb/host/isp116x-hcd.c
9 32 drivers/usb/host/fotg210-hcd.c
7 29 drivers/usb/host/oxu210hp-hcd.c
6 4 drivers/usb/host/sl811_cs.c

I'll fix ehci-hcd. Do you want patches for the others?

I'll fix the alignment using two extra tabs instead of aligning with
opening parenthesis. Thank you.


-- 
Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH 06/14] RFC: usb/host/fotg210: replace msleep by  usleep_range Felipe Balbi <balbi@ti.com> - 2015-10-02 19:40 +0200
  Re: [PATCH 06/14] RFC: usb/host/fotg210: replace msleep by usleep_range Alan Stern <stern@rowland.harvard.edu> - 2015-10-02 20:00 +0200
    Re: [PATCH 06/14] RFC: usb/host/fotg210: replace msleep by usleep_range Peter Senna Tschudin <peter.senna@gmail.com> - 2015-10-04 12:00 +0200
      Re: [PATCH 06/14] RFC: usb/host/fotg210: replace msleep by usleep_range Alan Stern <stern@rowland.harvard.edu> - 2015-10-04 17:30 +0200

csiph-web