Re: [PATCH v2 5/7] 9p: xattr simplifications

From	Christoph Hellwig <hch@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 5/7] 9p: xattr simplifications
Date	2015-10-04 08:30 +0200
Message-ID	<qfKY1-FS-7@gated-at.bofh.it> (permalink)
References	<qbuRP-5fA-3@gated-at.bofh.it> <qbuRQ-5fA-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Sep 22, 2015 at 02:26:50PM +0200, Andreas Gruenbacher wrote:
>  
> +/**
> + * xattr_full_name  -  Compute full attribute name from suffix
> + *

Missing argument descriptions for a kdoc comment.

> +const char *xattr_full_name(const struct xattr_handler *handler,
> +			    const char *name)
> +{
> +	size_t prefix_len = strlen(handler->prefix);
> +
> +	/* assert(memcmp(name - prefix_len, handler->prefix, prefix_len) == 0); */

This either should be a real WARN_ON or go away.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 5/7] 9p: xattr simplifications Andreas Gruenbacher <agruenba@redhat.com> - 2015-09-22 14:30 +0200
  Re: [PATCH v2 5/7] 9p: xattr simplifications Christoph Hellwig <hch@infradead.org> - 2015-10-04 08:30 +0200

csiph-web