Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1239035

Re: [PATCH] mm/mmap.c: Remove redundant vma looping

Show all headers | View raw

On 10/4/15 04:09, Richard Weinberger wrote:
> With that change you're reintroducing an issue.
> Please see:
> commit 7cd5a02f54f4c9d16cf7fdffa2122bc73bb09b43
> Author: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Date:   Mon Aug 11 09:30:25 2008 +0200
> 
>     mm: fix mm_take_all_locks() locking order
> 
>     Lockdep spotted:
> 
>     =======================================================
>     [ INFO: possible circular locking dependency detected ]
>     2.6.27-rc1 #270
>     -------------------------------------------------------
>     qemu-kvm/2033 is trying to acquire lock:
>      (&inode->i_data.i_mmap_lock){----}, at: [<ffffffff802996cc>]
> mm_take_all_locks+0xc2/0xea
> 
>     but task is already holding lock:
>      (&anon_vma->lock){----}, at: [<ffffffff8029967a>]
> mm_take_all_locks+0x70/0xea
> 
>     which lock already depends on the new lock.
>

Oh, really. Thanks.

> 
> git blame often explains funky code. :-)
> 

Next, I shall check the git log before make patches, each time. :-)

Theoretically, the lock and unlock need to be symmetric, if we have to
lock f_mapping all firstly, then lock all anon_vma, probably, we also
need to unlock anon_vma all, then unlock all f_mapping.


Thanks.
-- 
Chen Gang (陈刚)

Open, share, and attitude like air, water, and life which God blessed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm/mmap.c: Remove redundant vma looping Chen Gang <xili_gchen_5257@hotmail.com> - 2015-10-03 21:40 +0200
  Re: [PATCH] mm/mmap.c: Remove redundant vma looping Richard Weinberger <richard.weinberger@gmail.com> - 2015-10-03 22:10 +0200
    Re: [PATCH] mm/mmap.c: Remove redundant vma looping Chen Gang <xili_gchen_5257@hotmail.com> - 2015-10-04 07:00 +0200
      Re: [PATCH] mm/mmap.c: Remove redundant vma looping Andrea Arcangeli <aarcange@redhat.com> - 2015-10-04 19:30 +0200
        RE: [PATCH] mm/mmap.c: Remove redundant vma looping Chen Gang <xili_gchen_5257@hotmail.com> - 2015-10-05 14:30 +0200

csiph-web