Re: Missing operand for tlbie instruction on Power7

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Segher Boessenkool <segher@kernel.crashing.org>
Newsgroups	linux.kernel
Subject	Re: Missing operand for tlbie instruction on Power7
Date	Sun, 04 Oct 2015 02:10:01 +0200
Message-ID	<qfF2h-El-1@gated-at.bofh.it> (permalink)
References	<qfaKS-7Fv-19@gated-at.bofh.it> <qfdSq-3Vb-25@gated-at.bofh.it> <qfeYb-5qP-15@gated-at.bofh.it> <qfgdB-78j-15@gated-at.bofh.it> <qfgGB-7W4-1@gated-at.bofh.it> <qfkKe-5fi-1@gated-at.bofh.it>
X-Original-To	Peter Bergner <bergner@vnet.ibm.com>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.4.2.3i
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	32
Organization	linux.* mail to news gateway
X-Original-Cc	Denis Kirjanov <kda@linux-powerpc.org>, "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>, Laura Abbott <labbott@redhat.com>, Paul Mackerras <paulus@samba.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
X-Original-Date	Sat, 3 Oct 2015 19:00:09 -0500
X-Original-Message-ID	<20151004000009.GA10997@gate.crashing.org>
X-Original-References	<560EA623.1040300@redhat.com> <CAOJe8K1gQFRakYVWPYe0j9+Zc+s9hqB7uFF_aZh9NwCZSfTB_w@mail.gmail.com> <1443816930.13186.214.camel@otta> <CAOJe8K2GOsBk=CcWaZqq9KN=McLad97BP6ZhEdRB7i2Ag4csOg@mail.gmail.com> <20151002220051.GA26712@gate.crashing.org> <1443839086.13186.219.camel@otta>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1239024

Show key headers only | View raw

On Fri, Oct 02, 2015 at 09:24:46PM -0500, Peter Bergner wrote:
> > > Ok, than we can just zero out r5 for example and use it in tlbie as RS,
> > > right?
> > 
> > That won't assemble _unless_ your assembler is in POWER7 mode.  It also
> > won't do the right thing at run time on older machines.
> 
> Correct, getting this to work on both pre-power7 and power7 and later
> is tricky.  One really horrible hack would be to do:
> 
>   li r0,0
>   tlbie r4,0
> 
> On pre-power7, the "0" will be taken as a zero L operand and on
> power7 and later, it'll be r0, but with a zero value we loaded in
> the insn before.  I know, really ugly. :-)

Hide the "li 0,0" somewhere earlier, and write it as "tlbie 4,0", and
don't write a comment -- we *like* tricky!

It should really be a separate macro define for power7 and 4xx etc.;
and the macro should not be called "tlbia", but something that makes
it obvious at the usage sites that it is in fact a macro; and why a
macro anyway, a function call might be better here?


Segher
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Missing operand for tlbie instruction on Power7 Laura Abbott <labbott@redhat.com> - 2015-10-02 17:50 +0200
  Re: Missing operand for tlbie instruction on Power7 Denis Kirjanov <kda@linux-powerpc.org> - 2015-10-02 21:10 +0200
    Re: Missing operand for tlbie instruction on Power7 Peter Bergner <bergner@vnet.ibm.com> - 2015-10-02 22:20 +0200
      Re: Missing operand for tlbie instruction on Power7 Denis Kirjanov <kda@linux-powerpc.org> - 2015-10-02 23:40 +0200
        Re: Missing operand for tlbie instruction on Power7 Segher Boessenkool <segher@kernel.crashing.org> - 2015-10-03 00:10 +0200
          Re: Missing operand for tlbie instruction on Power7 Laura Abbott <labbott@redhat.com> - 2015-10-03 00:20 +0200
          Re: Missing operand for tlbie instruction on Power7 Peter Bergner <bergner@vnet.ibm.com> - 2015-10-03 04:30 +0200
            Re: Missing operand for tlbie instruction on Power7 Segher Boessenkool <segher@kernel.crashing.org> - 2015-10-04 02:10 +0200

csiph-web