[PATCH 1/3] drivers: staging: wilc1000: Check for errors before kfree

From	Chandra S Gorentla <csgorentla@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH 1/3] drivers: staging: wilc1000: Check for errors before kfree
Date	2015-10-02 15:20 +0200
Message-ID	<qf8pI-4pZ-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

During the clean-up of the function, it is need to check if
errors occurred, not the memory pointer.

Signed-off-by: Chandra S Gorentla <csgorentla@gmail.com>
---
 drivers/staging/wilc1000/wilc_msgqueue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c b/drivers/staging/wilc1000/wilc_msgqueue.c
index d5ebd6d..1b73b63 100644
--- a/drivers/staging/wilc1000/wilc_msgqueue.c
+++ b/drivers/staging/wilc1000/wilc_msgqueue.c
@@ -105,7 +105,7 @@ int wilc_mq_send(WILC_MsgQueueHandle *pHandle,
 
 ERRORHANDLER:
 	/* error occured, free any allocations */
-	if (pstrMessage) {
+	if (result) {
 		kfree(pstrMessage->pvBuffer);
 		kfree(pstrMessage);
 	}
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] drivers: staging: wilc1000: Check for errors before kfree Chandra S Gorentla <csgorentla@gmail.com> - 2015-10-02 15:20 +0200
  [PATCH 3/3] drivers: staging: wilc1000: Do not return from function with lock is on Chandra S Gorentla <csgorentla@gmail.com> - 2015-10-02 15:20 +0200
  [PATCH 2/3] drivers: staging: wilc1000: Remove ineffective code Chandra S Gorentla <csgorentla@gmail.com> - 2015-10-02 15:20 +0200
  Re: [PATCH 1/3] drivers: staging: wilc1000: Check for errors before  kfree Dan Carpenter <dan.carpenter@oracle.com> - 2015-10-02 15:40 +0200
    Re: [PATCH 1/3] drivers: staging: wilc1000: Check for errors before  kfree Chandra Gorentla <csgorentla@gmail.com> - 2015-10-03 04:20 +0200

csiph-web