Re: [PATCH 01/17] rtc: pl031: remove misuse of IRQF_NO_SUSPEND flag

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 01/17] rtc: pl031: remove misuse of IRQF_NO_SUSPEND flag
Date	2015-10-02 15:20 +0200
Message-ID	<qf8pI-4pZ-19@gated-at.bofh.it> (permalink)
References	<qbbvQ-2wt-3@gated-at.bofh.it> <qbbFw-2I0-7@gated-at.bofh.it> <qf64x-WZ-7@gated-at.bofh.it> <qf64x-WZ-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 02/10/2015 at 11:45:18 +0100, Sudeep Holla wrote :
> 
> 
> On 02/10/15 11:40, Linus Walleij wrote:
> >On Mon, Sep 21, 2015 at 8:46 AM, Sudeep Holla <sudeep.holla@arm.com> wrote:
> >
> >>The IRQF_NO_SUSPEND flag is used to identify the interrupts that should
> >>be left enabled so as to allow them to work as expected during the
> >>suspend-resume cycle, but doesn't guarantee that it will wake the system
> >>from a suspended state, enable_irq_wake is recommended to be used for
> >>the wakeup.
> >>
> >>This patch removes the use of IRQF_NO_SUSPEND flags and uses newly
> >>introduce PM wakeup APIs dev_pm_{set,clear}_wake_irq.
> >>
> >>Cc: Linus Walleij <linus.walleij@linaro.org>
> >>Cc: Alessandro Zummo <a.zummo@towertech.it>
> >>Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> >>Cc: rtc-linux@googlegroups.com
> >>Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> >
> >Looks correct to me.
> >Acked-by: Linus Walleij <linus.walleij@linaro.org>
> >
> 
> Thanks, while you are at it, do you know what interrupt stv2_pl031
> shares so that I can fix the TODO in the comment or the code(whichever
> applicable).
> 

So that you know, I'm planning to apply them this weekend, I couldn't
find time to do it before.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH 01/17] rtc: pl031: remove misuse of IRQF_NO_SUSPEND flag Sudeep Holla <sudeep.holla@arm.com> - 2015-10-02 12:50 +0200
  Re: [PATCH 01/17] rtc: pl031: remove misuse of IRQF_NO_SUSPEND flag Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-10-02 15:20 +0200
  Re: [PATCH 01/17] rtc: pl031: remove misuse of IRQF_NO_SUSPEND flag Linus Walleij <linus.walleij@linaro.org> - 2015-10-05 10:50 +0200

csiph-web