[PATCH 07/18] Input: cap11xx - simplify function return logic

From	Javier Martinez Canillas <javier@osg.samsung.com>
Newsgroups	linux.kernel
Subject	[PATCH 07/18] Input: cap11xx - simplify function return logic
Date	2015-10-02 15:50 +0200
Message-ID	<qf8SJ-4YE-5@gated-at.bofh.it> (permalink)
References	<qf8SJ-4YE-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

The invoked function already returns zero on success or a negative
errno code so there is no need to open code the logic in the caller.

This also fixes the following make coccicheck warning:

drivers/input/keyboard/cap11xx.c:475:1-6: WARNING: end returns can be simplified

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/input/keyboard/cap11xx.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/input/keyboard/cap11xx.c b/drivers/input/keyboard/cap11xx.c
index 378db10001df..7240316ddfe3 100644
--- a/drivers/input/keyboard/cap11xx.c
+++ b/drivers/input/keyboard/cap11xx.c
@@ -472,12 +472,8 @@ static int cap11xx_i2c_probe(struct i2c_client *i2c_client,
 		return -ENXIO;
 	}
 
-	error = devm_request_threaded_irq(dev, irq, NULL, cap11xx_thread_func,
-					  IRQF_ONESHOT, dev_name(dev), priv);
-	if (error)
-		return error;
-
-	return 0;
+	return devm_request_threaded_irq(dev, irq, NULL, cap11xx_thread_func,
+					 IRQF_ONESHOT, dev_name(dev), priv);
 }
 
 static const struct of_device_id cap11xx_dt_ids[] = {
-- 
2.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 07/18] Input: cap11xx - simplify function return logic Javier Martinez Canillas <javier@osg.samsung.com> - 2015-10-02 15:50 +0200
  Re: [PATCH 07/18] Input: cap11xx - simplify function return logic Daniel Mack <daniel@zonque.org> - 2015-10-02 15:50 +0200
  Re: [PATCH 07/18] Input: cap11xx - simplify function return logic Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-10-02 20:10 +0200
    Re: [PATCH 07/18] Input: cap11xx - simplify function return logic Javier Martinez Canillas <javier@osg.samsung.com> - 2015-10-02 20:20 +0200

csiph-web