Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1238152

Re: [RFC PATCH 3/3] net: dsa: exit probe if no switch were found

From Neil Armstrong <narmstrong@baylibre.com>
Newsgroups linux.kernel
Subject Re: [RFC PATCH 3/3] net: dsa: exit probe if no switch were found
Date 2015-10-02 14:20 +0200
Message-ID <qf7tE-351-7@gated-at.bofh.it> (permalink)
References <qekVY-7TY-13@gated-at.bofh.it> <qeNXY-6n-19@gated-at.bofh.it> <qeP3I-1CP-21@gated-at.bofh.it>
Organization Baylibre

Show all headers | View raw


On 10/01/2015 06:32 PM, Andrew Lunn wrote:
> On Thu, Oct 01, 2015 at 05:27:32PM +0200, Neil Armstrong wrote:
>> On 09/30/2015 10:21 AM, Neil Armstrong wrote:
>>> If no switch were found in dsa_setup_dst, return -ENODEV and
>>> exit the dsa_probe cleanly.
> 
> ...
>  
>> Couldn't we use the probe defer mechanism here ? (until complete rework is done)
> 
> Hi Neil
> 
> I was thinking the same last night. We know the switch should be
> there, otherwise it would not be in DT. So returning -EPROBE_DEFER
> would be valid.
> 
>       Andrew
> 
Hi,

It makes sens but does a module insertion triggers the differed probe ?

I will still post this change in a next set of patch.

Neil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[RFC PATCH 3/3] net: dsa: exit probe if no switch were found Neil Armstrong <narmstrong@baylibre.com> - 2015-09-30 10:30 +0200
  Re: [RFC PATCH 3/3] net: dsa: exit probe if no switch were found Neil Armstrong <narmstrong@baylibre.com> - 2015-10-01 17:30 +0200
    Re: [RFC PATCH 3/3] net: dsa: exit probe if no switch were found Andrew Lunn <andrew@lunn.ch> - 2015-10-01 18:40 +0200
      Re: [RFC PATCH 3/3] net: dsa: exit probe if no switch were found Neil Armstrong <narmstrong@baylibre.com> - 2015-10-02 14:20 +0200
        Re: [RFC PATCH 3/3] net: dsa: exit probe if no switch were found Florian Fainelli <f.fainelli@gmail.com> - 2015-10-02 19:40 +0200

csiph-web