Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1237996

Re: [PATCH v3] kexec: fix out of the ELF headers buffer issue in syscall kexec_file_load()

Show all headers | View raw

* Andrew Morton <akpm@linux-foundation.org> wrote:

> On Tue, 29 Sep 2015 20:58:57 +0800 "Lee, Chun-Yi" <joeyli.kernel@gmail.com> wrote:
> 
> > This patch modified the code in fill_up_crash_elf_data by using
> > walk_system_ram_res instead of walk_system_ram_range to count the max
> > number of crash memory ranges. That's because the walk_system_ram_range
> > filters out small memory regions that are resided in the same page, but
> > walk_system_ram_res does not.
> > 
> > The oringial issue is page fault error that sometimes happened on big machines
> > when preparing ELF headers:
> > 
> > [  305.291522] BUG: unable to handle kernel paging request at ffffc90613fc9000
> > [  305.299621] IP: [<ffffffff8103d645>] prepare_elf64_ram_headers_callback+0x165/0x260
> > [  305.308300] PGD e000032067 PUD 6dcbec54067 PMD 9dc9bdeb067 PTE 0
> > [  305.315393] Oops: 0002 [#1] SMP
> > [...snip]
> > [  305.420953] task: ffff8e1c01ced600 ti: ffff8e1c03ec2000 task.ti: ffff8e1c03ec2000
> > [  305.429292] RIP: 0010:[<ffffffff8103d645>]  [<ffffffff8103d645>] prepare_elf64_ra
> > m_headers_callback+0x165/0x260
> > [...snip]
> > 
> > After tracing prepare_elf64_headers and prepare_elf64_ram_headers_callback,
> > the code uses walk_system_ram_res to fill-in crash memory regions information
> > to program header, so it counts those small memory regions that are resided in
> > a page area. But, when kernel was using walk_system_ram_range in
> > fill_up_crash_elf_data to count the number of crash memory regions, it filters
> > out small regions. I printed those small memory regions, for example:
> > 
> > kexec: Get nr_ram ranges. vaddr=0xffff880077592258 paddr=0x77592258, sz=0xdc0
> > 
> > Base on the code in walk_system_ram_range, this memory region will be filtered
> > out:
> > 
> > pfn = (0x77592258 + 0x1000 - 1) >> 12 = 0x77593
> > end_pfn = (0x77592258 + 0xfc0 -1 + 1) >> 12 = 0x77593
> > end_pfn - pfn = 0x77593 - 0x77593 = 0  <=== if (end_pfn > pfn) is FALSE
> > 
> > So, the max_nr_ranges that's counted by kernel doesn't include small memory
> > regions. That causes the page fault issue happened in later code path for
> > preparing EFL headers.
> > 
> > This issus is not easy to reproduce on small machines that don't have too
> > many CPUs because the allocated page aligned ELF buffer has more free space
> > to cover those small memory regions' PT_LOAD headers.
> > 
> 
> fyi, I added a cc:stable to my copy of this patch.

Note that I already have it applied, with a much improved changelog:

  e3c41e37b0f4 ("x86/kexec: Fix kexec crash in syscall kexec_file_load()")

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3] kexec: fix out of the ELF headers buffer issue in syscall kexec_file_load() "Lee, Chun-Yi" <joeyli.kernel@gmail.com> - 2015-09-29 15:00 +0200
  Re: [PATCH v3] kexec: fix out of the ELF headers buffer issue in  syscall kexec_file_load() Dave Young <dyoung@redhat.com> - 2015-09-30 05:10 +0200
  Re: [PATCH v3] kexec: fix out of the ELF headers buffer issue in  syscall kexec_file_load() Minfei Huang <mhuang@redhat.com> - 2015-09-30 13:30 +0200
  [tip:x86/urgent] x86/kexec:   Fix kexec crash in syscall kexec_file_load() "tip-bot for Lee, Chun-Yi" <tipbot@zytor.com> - 2015-10-01 11:00 +0200
  Re: [PATCH v3] kexec: fix out of the ELF headers buffer issue in  syscall kexec_file_load() Andrew Morton <akpm@linux-foundation.org> - 2015-10-02 01:10 +0200
    Re: [PATCH v3] kexec: fix out of the ELF headers buffer issue in  syscall kexec_file_load() Ingo Molnar <mingo@kernel.org> - 2015-10-02 09:20 +0200
  [tip:x86/urgent] x86/kexec:   Fix kexec crash in syscall kexec_file_load() "tip-bot for Lee, Chun-Yi" <tipbot@zytor.com> - 2015-10-02 09:20 +0200

csiph-web