Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1237989
| From | Jesper Nilsson <jesper.nilsson@axis.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: CRIS v32: leftover references on ETRAX_VIRTUAL_GPIO |
| Date | 2015-10-02 09:10 +0200 |
| Message-ID | <qf2DD-4Dq-3@gated-at.bofh.it> (permalink) |
| References | <qf2tY-4cT-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Oct 02, 2015 at 08:57:22AM +0200, Valentin Rothberg wrote:
> Hi Rabin,
Hi!
> your commit ("CRIS v32: remove old GPIO and LEDs code") is in today's
> linux-next tree (i.e., 20151002). Among other Kconfig options, the
> commit removes ETRAX_VIRTUAL_GPIO but leaves the following references in
> the code:
>
> 0 arch/cris/arch-v32/kernel/setup.c 132 #ifdef CONFIG_ETRAX_VIRTUAL_GPIO
> 1 arch/cris/arch-v32/kernel/setup.c 149 #ifdef CONFIG_ETRAX_VIRTUAL_GPIO
> 2 arch/cris/arch-v32/mach-fs/Kconfig 197 depends on ETRAX_VIRTUAL_GPIO
> 3 arch/cris/arch-v32/mach-fs/Kconfig 208 depends on ETRAX_VIRTUAL_GPIO
> 4 arch/cris/include/uapi/asm/etraxgpio.h 59 #ifdef CONFIG_ETRAX_VIRTUAL_GPIO
> 5 arch/cris/include/uapi/asm/etraxgpio.h 74 #ifdef CONFIG_ETRAX_VIRTUAL_GPIO
>
> Is it intentional or just an accident?
I'm guessing it's an accident, I did have some trouble applying that
particular patch and I had to verify the patch by hand, but I might
have made a mistake and removed something that Rabin didn't remove.
(Since I knew this symbol was tightly connected to the CRIS gpio)
Anyways, I'll roll a patch for removing them, thanks for the heads-up!
/Jesper
> I found the issue with scripts/checkkconfigsymbols.py.
>
> Kind regards,
> Valentin
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
CRIS v32: leftover references on ETRAX_VIRTUAL_GPIO Valentin Rothberg <valentinrothberg@gmail.com> - 2015-10-02 09:00 +0200 Re: CRIS v32: leftover references on ETRAX_VIRTUAL_GPIO Jesper Nilsson <jesper.nilsson@axis.com> - 2015-10-02 09:10 +0200 Re: CRIS v32: leftover references on ETRAX_VIRTUAL_GPIO Jesper Nilsson <jesper.nilsson@axis.com> - 2015-10-02 16:10 +0200
csiph-web