Re: [PATCH v2 2/8] spi: imx: replace fixed timeout with calculated one

From	"Bondarenko, Anton" <Anton_Bondarenko@mentor.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/8] spi: imx: replace fixed timeout with calculated one
Date	2015-10-01 02:20 +0200
Message-ID	<qezLk-44g-15@gated-at.bofh.it> (permalink)
References	<qcFrQ-8B-9@gated-at.bofh.it> <qcFBv-zc-3@gated-at.bofh.it> <qezLk-44g-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 30.09.2015 10:31, Robin Gong wrote:
> On Fri, Sep 25, 2015 at 07:57:09PM +0200, Anton Bondarenko wrote:
>> @@ -957,8 +988,10 @@ static int spi_imx_dma_transfer(struct spi_imx_data *spi_imx,
>>  		dmaengine_terminate_all(master->dma_tx);
>>  		dmaengine_terminate_all(master->dma_rx);
>>  	} else {
>> +		transfer_timeout = spi_imx_calculate_timeout(spi_imx,
>> +							     spi_imx->wml * 2);
> *2 again here? Although spi_imx_calculate_timeout has double it.
WIll be fixed in V3
>>  		timeout = wait_for_completion_timeout(
>> -				&spi_imx->dma_rx_completion, IMX_DMA_TIMEOUT);
>> +				&spi_imx->dma_rx_completion, transfer_timeout);
>>  		if (!timeout) {
>>  			pr_warn("%s %s: I/O Error in DMA RX\n",
>>  				dev_driver_string(&master->dev),
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v2 0/8] Improvements for SPI IMX driver for Freescale IMX53 and IMX6 families Anton Bondarenko <anton_bondarenko@mentor.com> - 2015-09-25 20:00 +0200
  [PATCH v2 2/8] spi: imx: replace fixed timeout with calculated one Anton Bondarenko <anton_bondarenko@mentor.com> - 2015-09-25 20:10 +0200
    Re: [PATCH v2 2/8] spi: imx: replace fixed timeout with calculated  one "Bondarenko, Anton" <Anton_Bondarenko@mentor.com> - 2015-10-01 02:20 +0200
  [PATCH v2 5/8] spi: imx: Add support for loopback for ECSPI controllers Anton Bondarenko <anton_bondarenko@mentor.com> - 2015-09-25 20:10 +0200
    Re: [PATCH v2 5/8] spi: imx: Add support for loopback for ECSPI  controllers "Bondarenko, Anton" <Anton_Bondarenko@mentor.com> - 2015-10-01 02:20 +0200

csiph-web