Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1236802

Re: [RFC/PATCH 11/11] arm: boot: dts: omap: add missing default status for 32k counter

Show all headers | View raw

On Wednesday 30 September 2015 09:12:09 Felipe Balbi wrote:
> On Wed, Sep 30, 2015 at 10:15:25AM +0200, Arnd Bergmann wrote:
> > On Tuesday 29 September 2015 15:44:06 Felipe Balbi wrote:
> > > All devices should have a default status. Ignoring
> > > the arguments if it should be 'okay' or 'disabled'
> > > by default, let's set them all the 'disabled' and
> > > have boards enable 32k counter.
> > > 
> > > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > > 
> > 
> > The patch looks good, but the description is slightly incorrect:
> > There is no reason to list "status='okay'" other than overriding
> > the 'disabled' status.
> > 
> > I'd phrase it something like:
> > 
> > "We want the use of the 32k counter to be a per-board setting,
> > so let's disable it by default in each dtsi file and override the
> > setting in the boards. Any board that does not wire up the counter
> > should leave it disabled".
> > 
> > However, if you really want all boards to provide the counter all
> > the time, I'd argue that we're better off dropping this patch. We
> > use the status="disabled" trick for anything that may or may not
> > be working based on the board design, but things that are present
> > everywhere don't need this.
> 
> okay, so here's the thing. While fiddling with the 32k counter, I noticed
> that even though there was no status listed, the thing still initializes
> fine. However, when moving 32k to drivers/clocksource and using
> CLOCKSOURCE_OF_DECLARE(), 32k would *NOT* probe unless I had an explicit
> status = "okay" in DT.

Very strange, that sounds like a bug in the clocksource probe code.
Can you check how this happens?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC/PATCH 11/11] arm: boot: dts: omap: add missing default status for 32k counter Felipe Balbi <balbi@ti.com> - 2015-09-29 22:50 +0200
  Re: [RFC/PATCH 11/11] arm: boot: dts: omap: add missing default status for 32k counter Arnd Bergmann <arnd@arndb.de> - 2015-09-30 10:20 +0200
    Re: [RFC/PATCH 11/11] arm: boot: dts: omap: add missing default  status for 32k counter Felipe Balbi <balbi@ti.com> - 2015-09-30 16:20 +0200
      Re: [RFC/PATCH 11/11] arm: boot: dts: omap: add missing default status for 32k counter Arnd Bergmann <arnd@arndb.de> - 2015-10-01 00:00 +0200
        Re: [RFC/PATCH 11/11] arm: boot: dts: omap: add missing default  status for 32k counter Felipe Balbi <balbi@ti.com> - 2015-10-05 20:00 +0200
          Re: [RFC/PATCH 11/11] arm: boot: dts: omap: add missing default status for 32k counter Felipe Balbi <balbi@ti.com> - 2015-10-05 21:50 +0200
  Re: [RFC/PATCH 11/11] arm: boot: dts: omap: add missing default  status for 32k counter Tony Lindgren <tony@atomide.com> - 2015-10-05 12:50 +0200

csiph-web