Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1236791
| Path | csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Florian Fainelli <f.fainelli@gmail.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [RFC PATCH 1/3] net: dsa: Use devm_ prefixed allocations |
| Date | Wed, 30 Sep 2015 23:50:02 +0200 |
| Message-ID | <qexqa-AE-3@gated-at.bofh.it> (permalink) |
| References | <qekVZ-7TY-23@gated-at.bofh.it> <qexgu-oR-19@gated-at.bofh.it> |
| X-Original-To | Fabio Estevam <festevam@gmail.com>, Neil Armstrong <narmstrong@baylibre.com> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=BLHdQZdfyLE0Bas4hB/fef7tt6e+qk9/mvwNr+6Swfk=; b=X/zlyZjgev1DWfm5aSFZ3kpMEMIET4gXn4HfT0WdFUSEs+A6MpK5Y9jrpKpmpMjSZO 3cltyHuiFotl0uOjaS6+UMfAj1P4Uj4GdI5u+/SYVhtHNKhPjPQThpaq7QYEz9tCmNjo Cyrjpr97ssAFSvUamYx3Qfjh/eoE80BUOWw56QVuH3/DiZXS9zphDO/61rEZnZy7W8jr EdAfqEmtuOiui9wo5a9DcYPRzcd47Am0R/Q7GSqk2gnax0uEu4Jl6NPSmgBv9g1+lYfW YXe505EYpeYBRCeTOXOoXi+YBt8ub8JLrQH/Hikrr5aQwFGz5Q98xC0OzlDzSKazgTKH U0Wg== |
| X-Received | by 10.66.189.69 with SMTP id gg5mr7649030pac.28.1443649256946; Wed, 30 Sep 2015 14:40:56 -0700 (PDT) |
| User-Agent | Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=utf-8 |
| Content-Transfer-Encoding | 7bit |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 45 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | "David S. Miller" <davem@davemloft.net>, Jesper Dangaard Brouer <brouer@redhat.com>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, linux-kernel <linux-kernel@vger.kernel.org>, Andrew Lunn <andrew@lunn.ch> |
| X-Original-Date | Wed, 30 Sep 2015 14:40:43 -0700 |
| X-Original-Message-ID | <560C56DB.6040404@gmail.com> |
| X-Original-References | <560B9B74.3080905@baylibre.com> <CAOMZO5A6UyLN2w3jsQB4r48-jOfKep6abkW0p+-Emsg0-hvkRw@mail.gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1236791 |
Show key headers only | View raw
On 30/09/15 14:34, Fabio Estevam wrote:
> On Wed, Sep 30, 2015 at 5:21 AM, Neil Armstrong <narmstrong@baylibre.com> wrote:
>> To simplify and prevent memory leakage when unbinding, use
>> the devm_ memory allocation calls.
>>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>> net/dsa/dsa.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c
>> index c59fa5d..98f94c2 100644
>> --- a/net/dsa/dsa.c
>> +++ b/net/dsa/dsa.c
>> @@ -305,7 +305,7 @@ static int dsa_switch_setup_one(struct dsa_switch *ds, struct device *parent)
>> if (ret < 0)
>> goto out;
>>
>> - ds->slave_mii_bus = mdiobus_alloc();
>> + ds->slave_mii_bus = devm_mdiobus_alloc(parent);
>> if (ds->slave_mii_bus == NULL) {
>> ret = -ENOMEM;
>> goto out;
>> @@ -400,7 +400,7 @@ dsa_switch_setup(struct dsa_switch_tree *dst, int index,
>> /*
>> * Allocate and initialise switch state.
>> */
>> - ds = kzalloc(sizeof(*ds) + drv->priv_size, GFP_KERNEL);
>> + ds = devm_kzalloc(parent, sizeof(*ds) + drv->priv_size, GFP_KERNEL);
>
> Shouldn't devm_ functions be called only from probe and remove functions?
That's the case AFAICT, the call chain looks like this:
dsa_probe()
-> dsa_setup_dst()
-> dsa_switch_setup()
-> dsa_switch_setup_one()
--
Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC PATCH 1/3] net: dsa: Use devm_ prefixed allocations Neil Armstrong <narmstrong@baylibre.com> - 2015-09-30 10:30 +0200
Re: [RFC PATCH 1/3] net: dsa: Use devm_ prefixed allocations Andrew Lunn <andrew@lunn.ch> - 2015-09-30 23:30 +0200
Re: [RFC PATCH 1/3] net: dsa: Use devm_ prefixed allocations Fabio Estevam <festevam@gmail.com> - 2015-09-30 23:40 +0200
Re: [RFC PATCH 1/3] net: dsa: Use devm_ prefixed allocations Florian Fainelli <f.fainelli@gmail.com> - 2015-09-30 23:50 +0200
Re: [RFC PATCH 1/3] net: dsa: Use devm_ prefixed allocations Florian Fainelli <f.fainelli@gmail.com> - 2015-09-30 23:50 +0200
csiph-web