Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1236762
| From | Johan Hovold <johan@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 8/8] mfd: lm3533: Simplify function return logic |
| Date | 2015-09-30 23:10 +0200 |
| Message-ID | <qewNr-8fj-9@gated-at.bofh.it> (permalink) |
| References | <qe1gB-53J-3@gated-at.bofh.it> <qe1gC-53J-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Sep 29, 2015 at 01:26:08PM +0200, Javier Martinez Canillas wrote: > The invoked functions already return zero on success or a negative > errno code so there is no need to open code the logic in the caller. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> I do not consider this an improvement in any way and suggest this patch is dropped. > --- > > drivers/mfd/lm3533-core.c | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c > index 643f3750e830..193ecee1fa7e 100644 > --- a/drivers/mfd/lm3533-core.c > +++ b/drivers/mfd/lm3533-core.c > @@ -472,11 +472,7 @@ static int lm3533_device_setup(struct lm3533 *lm3533, > if (ret) > return ret; > > - ret = lm3533_set_boost_ovp(lm3533, pdata->boost_ovp); > - if (ret) > - return ret; > - > - return 0; > + return lm3533_set_boost_ovp(lm3533, pdata->boost_ovp); You're saving a few lines of code but instead introduce asymmetries and obscure the fact that the function returns zero on success. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 8/8] mfd: lm3533: Simplify function return logic Javier Martinez Canillas <javier@osg.samsung.com> - 2015-09-29 13:30 +0200
Re: [PATCH 8/8] mfd: lm3533: Simplify function return logic Johan Hovold <johan@kernel.org> - 2015-09-30 23:10 +0200
Re: [PATCH 8/8] mfd: lm3533: Simplify function return logic Javier Martinez Canillas <javier@osg.samsung.com> - 2015-09-30 23:50 +0200
Re: [PATCH 8/8] mfd: lm3533: Simplify function return logic Johan Hovold <johan@kernel.org> - 2015-10-01 00:00 +0200
Re: [PATCH 8/8] mfd: lm3533: Simplify function return logic Lee Jones <lee.jones@linaro.org> - 2015-10-01 09:20 +0200
Re: [PATCH 8/8] mfd: lm3533: Simplify function return logic Johan Hovold <johan@kernel.org> - 2015-10-01 20:00 +0200
csiph-web