Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1236703

Re: [RESEND PATCH v3 1/1] Add Corsair Vengeance K90 driver

Show all headers | View raw

On Wed, 30 Sep 2015, Clément Vuchener wrote:

> This patch implements a HID driver for the Corsair Vengeance K90 keyboard.
> 
> It fixes the behaviour of the keys using incorrect HID usage codes and 
> exposes the macro playback mode and current profile to the user space 
> through sysfs attributes. It also adds two LED class devices controlling 
> the "record" LED and the backlight.
> 
> Signed-off-by: Clément Vuchener <clement.vuchener@gmail.com>
[ ... snip ... ]
> +struct k90_led {
> +	struct led_classdev cdev;
> +	int brightness;
> +	struct work_struct work;
> +	int removed;

This could be made bool.

Also the patch subject doesn't really follow the usual format we're using 
in hid.git.

Otherwise I like the code, thanks a lot for working on the driver. I have 
fixed the nits above and it's now queued in hid.git#for-4.4/corsair.

-- 
Jiri Kosina
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RESEND PATCH v3 0/1] Corsair Vengeance K90 driver Clément Vuchener <clement.vuchener@gmail.com> - 2015-09-30 15:20 +0200
  [RESEND PATCH v3 1/1] Add Corsair Vengeance K90 driver Clément Vuchener <clement.vuchener@gmail.com> - 2015-09-30 15:20 +0200
    Re: [RESEND PATCH v3 1/1] Add Corsair Vengeance K90 driver Jiri Kosina <jikos@kernel.org> - 2015-09-30 21:40 +0200

csiph-web