Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1236584
| From | Nathan Lynch <Nathan_Lynch@mentor.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] ARM: fix vdsomunge depends on glibc specific byteswap.h |
| Date | 2015-09-30 19:40 +0200 |
| Message-ID | <qetwe-3ox-39@gated-at.bofh.it> (permalink) |
| References | <qerXs-14n-15@gated-at.bofh.it> <qerXs-14n-13@gated-at.bofh.it> <qes77-1uV-3@gated-at.bofh.it> <qesgO-1GU-41@gated-at.bofh.it> <qesgO-1GU-39@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 09/30/2015 11:17 AM, Ard Biesheuvel wrote: > On 30 September 2015 at 18:13, H. Nikolaus Schaller <hns@goldelico.com> wrote: >> >> Am 30.09.2015 um 18:02 schrieb Ard Biesheuvel <ard.biesheuvel@linaro.org>: >>> >>> Have you tried this? >>> >>> #define bswap_16 __builtin_bswap16 >>> #define bswap_32 __builtin_bswap32 >>> #define bswap_64 __builtin_bswap64 >>> >>> https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html >> >> OS X host uses llvm and I am not sure if these builtins are >> always available. >> > > I am pretty sure recent clang supports these as well. Could you please try it? Well, I think GCC did not provide __builtin_bswap16 consistently until the 4.8 release: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52624 That seems too recent to me. vdsomunge makes only three or four potentially byteswapped accesses to the ELF header. It's not worth a lot of effort to try to use the most optimal implementation available. Why not just use a generic implementation like is found in mips' elf2ecoff? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] ARM: fix vdsomunge depends on glibc specific byteswap.h "H. Nikolaus Schaller" <hns@goldelico.com> - 2015-09-30 18:00 +0200
Re: [PATCH] ARM: fix vdsomunge depends on glibc specific byteswap.h Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2015-09-30 18:10 +0200
Re: [PATCH] ARM: fix vdsomunge depends on glibc specific byteswap.h "H. Nikolaus Schaller" <hns@goldelico.com> - 2015-09-30 18:20 +0200
Re: [PATCH] ARM: fix vdsomunge depends on glibc specific byteswap.h Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2015-09-30 18:20 +0200
Re: [PATCH] ARM: fix vdsomunge depends on glibc specific byteswap.h "H. Nikolaus Schaller" <hns@goldelico.com> - 2015-09-30 19:30 +0200
Re: [PATCH] ARM: fix vdsomunge depends on glibc specific byteswap.h Nathan Lynch <Nathan_Lynch@mentor.com> - 2015-09-30 19:40 +0200
Re: [PATCH] ARM: fix vdsomunge depends on glibc specific byteswap.h "H. Nikolaus Schaller" <hns@goldelico.com> - 2015-09-30 19:50 +0200
Re: [PATCH] ARM: fix vdsomunge depends on glibc specific byteswap.h Nathan Lynch <Nathan_Lynch@mentor.com> - 2015-09-30 20:20 +0200
Re: [PATCH] ARM: fix vdsomunge depends on glibc specific byteswap.h "H. Nikolaus Schaller" <hns@goldelico.com> - 2015-09-30 21:10 +0200
[PATCH v2] ARM: fix vdsomunge not to depend on glibc specific byteswap.h "H. Nikolaus Schaller" <hns@goldelico.com> - 2015-10-03 22:50 +0200
csiph-web