Re: [PATCH 1/6] Revert "regulator: core: Handle full constraints systems when resolving supplies"

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/6] Revert "regulator: core: Handle full constraints systems when resolving supplies"
Date	2015-09-30 20:10 +0200
Message-ID	<qetZf-4bK-9@gated-at.bofh.it> (permalink)
References	<qeqf0-7dN-3@gated-at.bofh.it> <qeqf1-7dN-43@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Sep 30, 2015 at 04:05:41PM +0200, Sascha Hauer wrote:
> This reverts commit 9f7e25edb1575a6d2363dc003f9cc09d840657e2.
> 
> When a regulator A is registered and is supplied by regulator B which is
> not yet registered then a regulator_get on regulator A will set the As
> supply to the dummy regulator. This is not correct, we should return
> -EPROBE_DEFER instead as done without this patch.

What makes you say this is not correct?  In a system with fully
specified supplies if we fail to resolve the supply we know that no
supply will ever appear and so substitute in the dummy on the assumption
that there is a supply with no software control.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC] regulator: Propagate voltage changes to supply regulators Sascha Hauer <s.hauer@pengutronix.de> - 2015-09-30 16:10 +0200
  [PATCH 1/6] Revert "regulator: core: Handle full constraints systems when resolving supplies" Sascha Hauer <s.hauer@pengutronix.de> - 2015-09-30 16:10 +0200
    Re: [PATCH 1/6] Revert "regulator: core: Handle full constraints  systems when resolving supplies" Mark Brown <broonie@kernel.org> - 2015-09-30 20:10 +0200

csiph-web