Re: [PATCH v2] mtd: mtdram: fix build error

From	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] mtd: mtdram: fix build error
Date	2015-09-30 18:30 +0200
Message-ID	<qesqv-1Sg-45@gated-at.bofh.it> (permalink)
References	<qepCi-6f9-13@gated-at.bofh.it> <qerXt-14n-49@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Sep 30, 2015 at 08:51:07AM -0700, Brian Norris wrote:
> On Wed, Sep 30, 2015 at 06:59:26PM +0530, Sudip Mukherjee wrote:
> > i386 allmodconfig fails with:
> > ERROR: "__umoddi3" [drivers/mtd/devices/mtdram.ko] undefined!
> > ERROR: "__moddi3" [drivers/mtd/devices/mtdram.ko] undefined!
> > 
> > arm allmodconfig fails with:
> > ERROR: "__aeabi_uldivmod" [drivers/mtd/devices/mtdram.ko] undefined!
> > ERROR: "__aeabi_ldivmod" [drivers/mtd/devices/mtdram.ko] undefined!
> > 
> > mips allmodconfig fails with:
> > ERROR: "__umoddi3" [drivers/mtd/devices/mtdram.ko] undefined!
> > ERROR: "__moddi3" [drivers/mtd/devices/mtdram.ko] undefined!
> > 
> > The modulus operation is not being supported by these compilers. Use
> > do_div() instead which returns the remainder.
> > 
> > Fixes: 7827e3acad2d ("mtd: mtdram: check offs and len in mtdram->erase")
> > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> > ---
> > 
> > v1 showed build warning with cris and xtensa. I have checked v2 with
> > arm, cris and xtensa.
> 
> I already reverted the bad patch, so this doesn't apply any more...
> 
> If you want to send a squashed patch that redoes this properly, I can
> take it.

Ok. Sending the new patch.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] mtd: mtdram: fix build error Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-09-30 15:30 +0200
  Re: [PATCH v2] mtd: mtdram: fix build error Brian Norris <computersforpeace@gmail.com> - 2015-09-30 18:00 +0200
    Re: [PATCH v2] mtd: mtdram: fix build error Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-09-30 18:30 +0200

csiph-web