Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1236504

[PATCH 02/16] clk: at91: system: don't try to free_irq when there is no IRQ

Show all headers | View raw

In the error path of at91_clk_register_system(), sys->irq is freed
unconditionally but it may not exist or be request at all.

Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
 drivers/clk/at91/clk-system.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/clk/at91/clk-system.c b/drivers/clk/at91/clk-system.c
index 58008b3e8bc1..3f5314344286 100644
--- a/drivers/clk/at91/clk-system.c
+++ b/drivers/clk/at91/clk-system.c
@@ -138,7 +138,8 @@ at91_clk_register_system(struct at91_pmc *pmc, const char *name,
 
 	clk = clk_register(NULL, &sys->hw);
 	if (IS_ERR(clk)) {
-		free_irq(sys->irq, sys);
+		if (irq)
+			free_irq(sys->irq, sys);
 		kfree(sys);
 	}
 
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/16] ARM: at91: PMC driver rework Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-09-30 18:20 +0200
  [PATCH 06/16] clk: at91: clk-main: factorize irq handling Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-09-30 18:20 +0200
    Re: [PATCH 06/16] clk: at91: clk-main: factorize irq handling Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-10-01 10:40 +0200
  [PATCH 03/16] ARM: at91/dt: use syscon for PMC Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-09-30 18:20 +0200
  [PATCH 07/16] clk: at91: make IRQ optional and register them later Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-09-30 18:20 +0200
  [PATCH 11/16] ARM: at91: pm: simply call at91_pm_init Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-09-30 18:20 +0200
  [PATCH 10/16] clk: at91: pmc: move pmc structures to C file Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-09-30 18:20 +0200
  [PATCH 14/16] ARM: at91: remove useless includes and function prototypes Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-09-30 18:20 +0200
  [PATCH 16/16] clk: at91: pmc: drop at91_pmc_base Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-09-30 18:20 +0200
  [PATCH 02/16] clk: at91: system: don't try to free_irq when there is no IRQ Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-09-30 18:20 +0200
  [PATCH 12/16] ARM: at91: pm: find and remap the pmc Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-09-30 18:20 +0200
  [PATCH 15/16] usb: gadget: atmel: access the PMC using regmap Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-09-30 18:20 +0200
    Re: [PATCH 15/16] usb: gadget: atmel: access the PMC using regmap Felipe Balbi <balbi@ti.com> - 2015-09-30 18:40 +0200
      Re: [PATCH 15/16] usb: gadget: atmel: access the PMC using regmap Nicolas Ferre <nicolas.ferre@atmel.com> - 2015-09-30 18:40 +0200
        Re: [PATCH 15/16] usb: gadget: atmel: access the PMC using regmap Felipe Balbi <balbi@ti.com> - 2015-09-30 18:50 +0200
      Re: [PATCH 15/16] usb: gadget: atmel: access the PMC using regmap Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-09-30 19:00 +0200
        Re: [PATCH 15/16] usb: gadget: atmel: access the PMC using regmap Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-09-30 19:10 +0200
  [PATCH 01/16] clk: at91: utmi: use pmc_read when the at91_pmc is available Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-09-30 18:20 +0200
  [PATCH 13/16] ARM: at91: pm: move idle functions to pm.c Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-09-30 18:20 +0200
  [PATCH 08/16] clk: at91: only enable available IRQs Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-09-30 18:20 +0200
    Re: [PATCH 08/16] clk: at91: only enable available IRQs Ludovic Desroches <ludovic.desroches@atmel.com> - 2015-10-01 10:30 +0200
  Re: [PATCH 00/16] ARM: at91: PMC driver rework Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-09-30 18:30 +0200

csiph-web