Re: [PATCH 2/5] selinux: remove pointless cast in selinux_inode_setsecurity()

From	Paul Moore <paul@paul-moore.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/5] selinux: remove pointless cast in selinux_inode_setsecurity()
Date	2015-09-30 18:40 +0200
Message-ID	<qesA9-23w-11@gated-at.bofh.it> (permalink)
References	<qcJON-6x2-3@gated-at.bofh.it> <qcJOO-6x2-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Saturday, September 26, 2015 12:34:16 AM Rasmus Villemoes wrote:
> security_context_to_sid() expects a const char* argument, so there's
> no point in casting away the const qualifier of value.
> 
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
>  security/selinux/hooks.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied.

> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index fd50cd5ac2ec..5edb57df86f8 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -3162,7 +3162,7 @@ static int selinux_inode_setsecurity(struct inode
> *inode, const char *name, if (!value || !size)
>  		return -EACCES;
> 
> -	rc = security_context_to_sid((void *)value, size, &newsid, GFP_KERNEL);
> +	rc = security_context_to_sid(value, size, &newsid, GFP_KERNEL);
>  	if (rc)
>  		return rc;

-- 
paul moore
www.paul-moore.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/5] selinux: remove pointless cast in selinux_inode_setsecurity() Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-09-26 00:40 +0200
  Re: [PATCH 2/5] selinux: remove pointless cast in  selinux_inode_setsecurity() Stephen Smalley <sds@tycho.nsa.gov> - 2015-09-29 20:10 +0200
  Re: [PATCH 2/5] selinux: remove pointless cast in selinux_inode_setsecurity() Paul Moore <paul@paul-moore.com> - 2015-09-30 18:40 +0200

csiph-web