Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1236453

Re: [PATCH 2/3] leds: add debugfs to device trigger

From Maciek Borzecki <maciek.borzecki@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/3] leds: add debugfs to device trigger
Date 2015-09-30 17:50 +0200
Message-ID <qerNN-SV-35@gated-at.bofh.it> (permalink)
References <qdNx1-23T-25@gated-at.bofh.it> <qdNx1-23T-23@gated-at.bofh.it> <qeqf0-7dN-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 09/30 16:08, Jacek Anaszewski wrote:
> Hi Maciek,
>
> Please test your solution thoroughly before submitting
> the next version. Writing to debugfs register attribute
> fails due to lack of proper copying from user memory,
> which makes testing impossible.

Hi, thanks for the comment. Indeed, I noticed the problem just after
sending the patch. Surprisingly this didn't fail on iMX6 for some
reason.

Aside from the __user access problem, is the approach, in general, ok for
you or would you suggest that I changed something?

Regards,
--
Maciek Borzecki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] leds: add device trigger Maciek Borzecki <maciek.borzecki@gmail.com> - 2015-09-28 22:50 +0200
  [PATCH 2/3] leds: add debugfs to device trigger Maciek Borzecki <maciek.borzecki@gmail.com> - 2015-09-28 22:50 +0200
    Re: [PATCH 2/3] leds: add debugfs to device trigger kbuild test robot <lkp@intel.com> - 2015-09-29 05:50 +0200
      Re: [PATCH 2/3] leds: add debugfs to device trigger Maciek Borzecki <maciek.borzecki@gmail.com> - 2015-09-29 09:10 +0200
    Re: [PATCH 2/3] leds: add debugfs to device trigger Jacek Anaszewski <j.anaszewski@samsung.com> - 2015-09-30 16:10 +0200
      Re: [PATCH 2/3] leds: add debugfs to device trigger Maciek Borzecki <maciek.borzecki@gmail.com> - 2015-09-30 17:50 +0200
        Re: [PATCH 2/3] leds: add debugfs to device trigger Jacek Anaszewski <j.anaszewski@samsung.com> - 2015-10-01 09:40 +0200
  [PATCH 3/3] Documentation: leds: document ledtrig-device trigger Maciek Borzecki <maciek.borzecki@gmail.com> - 2015-09-28 22:50 +0200

csiph-web