Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1236281

Re: [PATCH v2 4/6] tty: serial: msm: Add TX DMA support

From Mark Rutland <mark.rutland@arm.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 4/6] tty: serial: msm: Add TX DMA support
Date 2015-09-30 15:30 +0200
Message-ID <qepCi-6f9-3@gated-at.bofh.it> (permalink)
References <qeomS-4wT-3@gated-at.bofh.it> <qeomS-4wT-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Sep 30, 2015 at 01:08:24PM +0100, Ivan T. Ivanov wrote:
> Add transmit DMA support for UARTDM type of controllers.
> 
> Tested on APQ8064, which have UARTDM v1.3 and ADM DMA engine
> and APQ8016, which have UARTDM v1.4 and BAM DMA engine.
> 
> Signed-off-by: Ivan T. Ivanov <ivan.ivanov@linaro.org>
> ---
>  .../devicetree/bindings/serial/qcom,msm-uartdm.txt |   3 +
>  drivers/tty/serial/msm_serial.c                    | 312 +++++++++++++++++++--
>  drivers/tty/serial/msm_serial.h                    |   3 +
>  3 files changed, 294 insertions(+), 24 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/serial/qcom,msm-uartdm.txt b/Documentation/devicetree/bindings/serial/qcom,msm-uartdm.txt
> index a2114c217376..a600023d9ec1 100644
> --- a/Documentation/devicetree/bindings/serial/qcom,msm-uartdm.txt
> +++ b/Documentation/devicetree/bindings/serial/qcom,msm-uartdm.txt
> @@ -26,6 +26,9 @@ Required properties:
>  Optional properties:
>  - dmas: Should contain dma specifiers for transmit and receive channels
>  - dma-names: Should contain "tx" for transmit and "rx" for receive channels
> +- qcom,tx-crci: Identificator <u32> for Client Rate Control Interface to be
> +           used with TX DMA channel. Required when using DMA for transmission
> +           with UARTDM v1.3 and bellow.

This sounds like it belongs in the dma-specifier, and dealt with by the
DMA controller driver.

Why does the UART driver need to know about this?

Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 4/6] tty: serial: msm: Add TX DMA support "Ivan T. Ivanov" <ivan.ivanov@linaro.org> - 2015-09-30 14:10 +0200
  Re: [PATCH v2 4/6] tty: serial: msm: Add TX DMA support Mark Rutland <mark.rutland@arm.com> - 2015-09-30 15:30 +0200
    Re: [PATCH v2 4/6] tty: serial: msm: Add TX DMA support "Ivan T. Ivanov" <ivan.ivanov@linaro.org> - 2015-09-30 16:00 +0200
      Re: [PATCH v2 4/6] tty: serial: msm: Add TX DMA support Mark Rutland <mark.rutland@arm.com> - 2015-09-30 19:40 +0200
        Re: [PATCH v2 4/6] tty: serial: msm: Add TX DMA support Andy Gross <agross@codeaurora.org> - 2015-09-30 22:30 +0200

csiph-web