Re: [PATCH v2 03/12] sched: Create preempt_count invariant

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 03/12] sched: Create preempt_count invariant
Date	2015-09-30 13:20 +0200
Message-ID	<qenAu-3ml-17@gated-at.bofh.it> (permalink)
References	<qek9A-6Kx-13@gated-at.bofh.it> <qek9A-6Kx-33@gated-at.bofh.it> <qem1J-Zq-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Sep 30, 2015 at 05:32:08AM -0400, Steven Rostedt wrote:
> On Wed, 30 Sep 2015 09:10:38 +0200
> Peter Zijlstra <peterz@infradead.org> wrote:
> > -#ifdef CONFIG_PREEMPT_COUNT
> > -#define PREEMPT_DISABLED	(1 + PREEMPT_ENABLED)
> > -#else
> > -#define PREEMPT_DISABLED	PREEMPT_ENABLED
> > -#endif
> > +#define PREEMPT_DISABLED	(PREEMPT_DISABLE_OFFSET + PREEMPT_ENABLED)
> 
> Hmm, it looks to me that you removed all users of PREEMPT_DISABLED.
> 
> Did you add another user of it?

Dunno, lemme go grep ;-)

include/linux/sched.h:#define PREEMPT_DISABLED  (PREEMPT_DISABLE_OFFSET + PREEMPT_ENABLED)
kernel/sched/core.c:            preempt_count_set(PREEMPT_DISABLED);

So there still is one user.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v2 03/12] sched: Create preempt_count invariant Peter Zijlstra <peterz@infradead.org> - 2015-09-30 09:40 +0200
  Re: [PATCH v2 03/12] sched: Create preempt_count invariant Steven Rostedt <rostedt@goodmis.org> - 2015-09-30 11:40 +0200
    Re: [PATCH v2 03/12] sched: Create preempt_count invariant Peter Zijlstra <peterz@infradead.org> - 2015-09-30 13:20 +0200
      Re: [PATCH v2 03/12] sched: Create preempt_count invariant Steven Rostedt <rostedt@goodmis.org> - 2015-09-30 15:40 +0200

csiph-web