Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1236097

Re: [PATCH] mm: fix overflow in find_zone_movable_pfns_for_nodes()

Show all headers | View raw

Seems OK to me.

Thanks.

On 09/30/2015 05:33 PM, Xishi Qiu wrote:
> If user set "movablecore=xx" to a large number, corepages will overflow,
> this patch fix the problem.
>
> Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
> ---
>   mm/page_alloc.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 48aaf7b..af3c9bd 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -5668,6 +5668,7 @@ static void __init find_zone_movable_pfns_for_nodes(void)
>   		 */
>   		required_movablecore =
>   			roundup(required_movablecore, MAX_ORDER_NR_PAGES);
> +		required_movablecore = min(totalpages, required_movablecore);
>   		corepages = totalpages - required_movablecore;
>   
>   		required_kernelcore = max(required_kernelcore, corepages);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm: fix overflow in find_zone_movable_pfns_for_nodes() Xishi Qiu <qiuxishi@huawei.com> - 2015-09-30 11:40 +0200
  Re: [PATCH] mm: fix overflow in find_zone_movable_pfns_for_nodes() Tang Chen <tangchen@cn.fujitsu.com> - 2015-09-30 12:40 +0200
  Re: [PATCH] mm: fix overflow in find_zone_movable_pfns_for_nodes() David Rientjes <rientjes@google.com> - 2015-09-30 23:10 +0200
  Re: [PATCH] mm: fix overflow in find_zone_movable_pfns_for_nodes() Yasuaki Ishimatsu <yasu.isimatu@gmail.com> - 2015-10-01 22:10 +0200

csiph-web