Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1235944

Re: [PATCH v2 07/12] sched: Robustify preemption leak checks

From Steven Rostedt <rostedt@goodmis.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2 07/12] sched: Robustify preemption leak checks
Date 2015-09-30 11:40 +0200
Message-ID <qem1J-Zq-31@gated-at.bofh.it> (permalink)
References <qek9A-6Kx-13@gated-at.bofh.it> <qek9B-6Kx-37@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, 30 Sep 2015 09:10:42 +0200
Peter Zijlstra <peterz@infradead.org> wrote:

> When we warn about a preempt_count leak; reset the preempt_count to
> the known good value such that the problem does not ripple forward.
> 
> This is most important on x86 which has a per cpu preempt_count that is
> not saved/restored (after this series). So if you schedule with an
> invalid (!2*PREEMPT_DISABLE_OFFSET) preempt_count the next task is
> messed up too.
> 
> Enforcing this invariant limits the borkage to just the one task.
> 
> Reviewed-by: Frederic Weisbecker <fweisbec@gmail.com>
> Reviewed-by: Thomas Gleixner <tglx@linutronix.de>

Reviewed-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve

> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> ---

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH v2 07/12] sched: Robustify preemption leak checks Peter Zijlstra <peterz@infradead.org> - 2015-09-30 09:40 +0200
  Re: [PATCH v2 07/12] sched: Robustify preemption leak checks Steven Rostedt <rostedt@goodmis.org> - 2015-09-30 11:40 +0200

csiph-web