Re: [PATCH] HID: hid-multitouch.c: fix formatting warnings

From	Jiri Kosina <jikos@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] HID: hid-multitouch.c: fix formatting warnings
Date	2015-09-30 10:00 +0200
Message-ID	<qeksW-76X-3@gated-at.bofh.it> (permalink)
References	<qdMUh-1fb-5@gated-at.bofh.it> <qe2FJ-6Wy-13@gated-at.bofh.it> <qe3V8-rR-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 29 Sep 2015, Brent Adam wrote:

> >> Fixed the following checkpatch.pl warnings:
> >> WARNING: line over 80 characters: line 163
> >> WARNING: Missing a blank line after declarations: line 359
> >> WARNING: Missing a blank line after declarations: line 572
> >> WARNING: Missing a blank line after declarations: line 708
> >> WARNING: Missing a blank line after declarations: line 926
> >> WARNING: Possible unnecessary 'out of memory' message: line 1034
> >> WARNING: Possible unnecessary 'out of memory' message: line 1048
> >> WARNING: line over 80 characters: line 1390
> >
> >For files which are already in tree I'd be taking such fixes only as a 
> >side-change if refactoring the code anyway in a substantial way. Otherwise 
> >I consider the ones below too minor to justify cluttering of git blame.
> 
> Ok, although Greg Kroah-Hartman inspires you in his video to submit patches
> to make the code checkpatch clean. https://www.youtube.com/watch?v=LLBrBBImJt4

HID is not a subsystem residing in drivers/staging playground though.

-- 
Jiri Kosina
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] HID: hid-multitouch.c: fix formatting warnings Brent Adam <brentadamdev@gmail.com> - 2015-09-28 22:10 +0200
  Re: [PATCH] HID: hid-multitouch.c: fix formatting warnings Jiri Kosina <jikos@kernel.org> - 2015-09-29 15:00 +0200
    Re: [PATCH] HID: hid-multitouch.c: fix formatting warnings Brent Adam <BrentAdam@smarttech.com> - 2015-09-29 16:20 +0200
      Re: [PATCH] HID: hid-multitouch.c: fix formatting warnings Jiri Kosina <jikos@kernel.org> - 2015-09-30 10:00 +0200

csiph-web