Re: [PATCH net-next] net: dsa: fix preparation of a port STP update

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next] net: dsa: fix preparation of a port STP update
Date	Wed, 30 Sep 2015 06:40:02 +0200
Message-ID	<qehlo-2JC-9@gated-at.bofh.it> (permalink)
References	<qe66E-3vi-53@gated-at.bofh.it>
X-Original-To	vivien.didelot@savoirfairelinux.com
X-Mailer	Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
MIME-Version	1.0
Content-Type	Text/Plain; charset=us-ascii
Content-Transfer-Encoding	7bit
X-Greylist	Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 29 Sep 2015 21:35:16 -0700 (PDT)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	18
Organization	linux.* mail to news gateway
X-Original-Cc	netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, andrew@lunn.ch
X-Original-Date	Tue, 29 Sep 2015 21:35:16 -0700 (PDT)
X-Original-Message-ID	<20150929.213516.1675265710298613345.davem@davemloft.net>
X-Original-References	<1443544716-9130-1-git-send-email-vivien.didelot@savoirfairelinux.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1235745

Show key headers only | View raw

From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Date: Tue, 29 Sep 2015 12:38:36 -0400

> Because of the default 0 value of ret in dsa_slave_port_attr_set, a
> driver may return -EOPNOTSUPP from the commit phase of a STP state,
> which triggers a WARN() from switchdev.
> 
> This happened on a 6185 switch which does not support hardware bridging.
> 
> Reported-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next] net: dsa: fix preparation of a port STP update Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-09-29 18:40 +0200
  Re: [PATCH net-next] net: dsa: fix preparation of a port STP update Andrew Lunn <andrew@lunn.ch> - 2015-09-29 19:00 +0200
    Re: [PATCH net-next] net: dsa: fix preparation of a port STP update Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-09-29 21:20 +0200
  Re: [PATCH net-next] net: dsa: fix preparation of a port STP update David Miller <davem@davemloft.net> - 2015-09-30 06:40 +0200

csiph-web