Re: [PATCH] ARM: exynos_defconfig: Enable WiFi-Ex as a module instead built-in

From	Krzysztof Kozlowski <k.kozlowski@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ARM: exynos_defconfig: Enable WiFi-Ex as a module instead built-in
Date	2015-09-30 02:40 +0200
Message-ID	<qedB7-5Kr-9@gated-at.bofh.it> (permalink)
References	<qe2w1-6Ln-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 29.09.2015 21:42, Javier Martinez Canillas wrote:
> The Marvell WiFi-Ex driver tries to load a firmware on probe. So if the
> driver is built-in and probed before a firmware is available, this is
> not loaded and the chip does not work.
> 
> This happens for example if an initramfs isn't used since the driver is
> probed before the root filesystem is mounted.
> 
> Change the default config since the driver isn't needed for machines to
> boot and is more convenient to have it enabled as a module to avoid
> requiring an initramfs or to have the firmware built into the kernel.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> ---
> 
>  arch/arm/configs/exynos_defconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

The user-space can always initiate re-probing of device - just re-bind
it. However I assume that driver cannot work without firmware?

Best regards,
Krzysztof

> 
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index d4f6063d8a72..5aad617f02c7 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -64,8 +64,8 @@ CONFIG_SMSC911X=y
>  CONFIG_USB_USBNET=y
>  CONFIG_USB_NET_SMSC75XX=y
>  CONFIG_USB_NET_SMSC95XX=y
> -CONFIG_MWIFIEX=y
> -CONFIG_MWIFIEX_SDIO=y
> +CONFIG_MWIFIEX=m
> +CONFIG_MWIFIEX_SDIO=m
>  CONFIG_INPUT_EVDEV=y
>  CONFIG_KEYBOARD_GPIO=y
>  CONFIG_KEYBOARD_CROS_EC=y
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] ARM: exynos_defconfig: Enable WiFi-Ex as a module instead built-in Javier Martinez Canillas <javier@osg.samsung.com> - 2015-09-29 14:50 +0200
  Re: [PATCH] ARM: exynos_defconfig: Enable WiFi-Ex as a module instead  built-in Andreas Färber <afaerber@suse.de> - 2015-09-29 15:30 +0200
    Re: [PATCH] ARM: exynos_defconfig: Enable WiFi-Ex as a module instead  built-in Javier Martinez Canillas <javier@osg.samsung.com> - 2015-09-29 16:00 +0200
  Re: [PATCH] ARM: exynos_defconfig: Enable WiFi-Ex as a module instead  built-in Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-09-30 02:40 +0200
    Re: [PATCH] ARM: exynos_defconfig: Enable WiFi-Ex as a module instead  built-in Javier Martinez Canillas <javier@osg.samsung.com> - 2015-09-30 09:30 +0200
      Re: [PATCH] ARM: exynos_defconfig: Enable WiFi-Ex as a module instead  built-in Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-09-30 09:40 +0200
        Re: [PATCH] ARM: exynos_defconfig: Enable WiFi-Ex as a module instead  built-in Javier Martinez Canillas <javier@osg.samsung.com> - 2015-09-30 10:00 +0200

csiph-web