Re: [PATCH 2/5] watchdog: move watchdog_disable_all_cpus() outside of ifdef

From	Andrew Morton <akpm@linux-foundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/5] watchdog: move watchdog_disable_all_cpus() outside of ifdef
Date	2015-09-30 01:40 +0200
Message-ID	<qecF3-4pC-1@gated-at.bofh.it> (permalink)
References	<qdNx0-23T-15@gated-at.bofh.it> <qdNx1-23T-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 28 Sep 2015 22:44:09 +0200 Ulrich Obergfell <uobergfe@redhat.com> wrote:

> It makes sense to place watchdog_{dis|enable}_all_cpus() outside of
> the ifdef so that _both_ are available even if CONFIG_SYSCTL is not
> defined.

Not really.  With CONFIG_SYSCTL=n this change will cause a compile
warning and will bloat up vmlinux.

I'll rewrite the changelog to

: Move watchdog_disable_all_cpus() outside of the ifdef so that it is
: available if CONFIG_SYSCTL is not defined.  This is preparation for
: "watchdog: implement error handling in update_watchdog_all_cpus() and
: callers".

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/5] watchdog: move watchdog_disable_all_cpus() outside of ifdef Ulrich Obergfell <uobergfe@redhat.com> - 2015-09-28 22:50 +0200
  Re: [PATCH 2/5] watchdog: move watchdog_disable_all_cpus() outside  of ifdef Aaron Tomlin <atomlin@redhat.com> - 2015-09-29 08:50 +0200
  Re: [PATCH 2/5] watchdog: move watchdog_disable_all_cpus() outside  of ifdef Andrew Morton <akpm@linux-foundation.org> - 2015-09-30 01:40 +0200

csiph-web